Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generators automatically assumes class when it should be enum #243

Closed
jonaslagoni opened this issue Jun 11, 2021 · 5 comments
Closed

Generators automatically assumes class when it should be enum #243

jonaslagoni opened this issue Jun 11, 2021 · 5 comments
Labels
bug Something isn't working generator Anything related to all generators
Milestone

Comments

@jonaslagoni
Copy link
Member

Describe the bug

The generator prefers other renders over enum which should be the other way around because enums are more strict.

How to Reproduce

Given the following JSON Schema:

{
  "type": "object",
  "properties": {
    "prop1": {
      "type": "object",
      "enum": [{"test": 2}]
    }
  }
}

prop1 is rendered as a class when it should have been an enum.

Expected behavior

Expected an enum to be generated.

@jonaslagoni jonaslagoni added bug Something isn't working generator Anything related to all generators labels Jun 11, 2021
@jonaslagoni jonaslagoni added this to the Version 1.0.0 milestone Jul 27, 2021
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Sep 26, 2021
@jonaslagoni
Copy link
Member Author

Still relevant.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jun 1, 2022
@jonaslagoni jonaslagoni removed the stale label Jun 7, 2022
@jonaslagoni
Copy link
Member Author

Solved in the next branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working generator Anything related to all generators
Projects
None yet
Development

No branches or pull requests

1 participant