Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better x-parser-schema-id #516

Closed
GreenRover opened this issue Apr 12, 2022 · 9 comments
Closed

Better x-parser-schema-id #516

GreenRover opened this issue Apr 12, 2022 · 9 comments
Labels
enhancement New feature or request stale

Comments

@GreenRover
Copy link
Contributor

Reason/Context

If there is not proper "x-parser-schema-id", meaning those "anonym..",
Modelina will end up with unusable classes.
But this is an issue for all code generator where you are not owner of the schema.

There are 2 Issues:

  • at the moment proper $id will only be generated by first level schemas. All sub schemas used in arrays or similar loose their name.
  • For string enum the $id could be generated by the field name, if not set.

I would suggest this to be enabled by an options to make it non breaking.

@GreenRover GreenRover added the enhancement New feature or request label Apr 12, 2022
@github-actions
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

GreenRover added a commit to GreenRover/asyncapi-parser-js that referenced this issue Apr 12, 2022
GreenRover added a commit to GreenRover/asyncapi-parser-js that referenced this issue Apr 12, 2022
This should be used when using it with a code generator like modelina
@magicmatatjahu
Copy link
Member

Similar issue #176

@GreenRover
Copy link
Contributor Author

I know but nothing happend there.
In my commit i would like to integrate instead using a preprocessor.

@jonaslagoni
Copy link
Member

Just gonna leave a reference here: asyncapi/parser-api#34

@GreenRover
Copy link
Contributor Author

@jonaslagoni How can we get here any progress?

@jonaslagoni
Copy link
Member

@jonaslagoni How can we get here any progress?

Would be awesome if you want to take the lead in pushing this change @GreenRover, as I am not sure when I will be able to focus on it myself.

We can set up a public meeting specifically for this if you want to? Or put it as part of a SIG meeting if you think that is more suiting? 🙂

GreenRover added a commit to GreenRover/asyncapi-parser-js that referenced this issue May 4, 2022
This should be used when using it with a code generator like modelina
GreenRover added a commit to GreenRover/asyncapi-parser-js that referenced this issue May 17, 2022
This should be used when using it with a code generator like modelina
GreenRover added a commit to GreenRover/asyncapi-parser-js that referenced this issue Jun 8, 2022
GreenRover added a commit to GreenRover/asyncapi-parser-js that referenced this issue Jun 8, 2022
GreenRover added a commit to GreenRover/asyncapi-parser-js that referenced this issue Jul 8, 2022
GreenRover added a commit to GreenRover/asyncapi-parser-js that referenced this issue Jul 8, 2022
GreenRover added a commit to GreenRover/asyncapi-parser-js that referenced this issue Jul 8, 2022
GreenRover added a commit to GreenRover/asyncapi-parser-js that referenced this issue Jul 8, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added stale and removed stale labels Aug 27, 2022
@magicmatatjahu
Copy link
Member

Still active.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Dec 28, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants