Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some tests for V3 message model are commented #838

Closed
smoya opened this issue Aug 10, 2023 · 1 comment
Closed

Some tests for V3 message model are commented #838

smoya opened this issue Aug 10, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@smoya
Copy link
Member

smoya commented Aug 10, 2023

Describe the bug

Some methods for the v3 model of Message are commented, so we do not know if the functionality behind those is working OK.

See https:/asyncapi/parser-js/blob/next-major-spec/test/models/v3/message.spec.ts#L74-L167

Expected behavior

We need to uncomment and fix anything we find.
@smoya smoya added the bug Something isn't working label Aug 10, 2023
This was referenced Aug 10, 2023
Closed
Merged
@smoya
Copy link
Member Author

smoya commented Aug 24, 2023

This is fixed now

@smoya smoya closed this as completed Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smoya