Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set proper parser-api version #849

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

smoya
Copy link
Member

@smoya smoya commented Aug 18, 2023

Description

This PR fixes the parser-api version in use from 1 to 2.0.0. It moves the value to a constant set in the same file as AsyncAPIDocumentInterface is declared.

@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this breaking? 🤔

@smoya
Copy link
Member Author

smoya commented Aug 18, 2023

Is this breaking? 🤔

Well, the breaking change is already in next-major-spec branch because it implements parser-api v2. I'm forcing the breaking change as major in #847

@jonaslagoni
Copy link
Member

@smoya 👍

@smoya
Copy link
Member Author

smoya commented Aug 18, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 95b6e5e into asyncapi:next-major-spec Aug 18, 2023
20 checks passed
@smoya smoya deleted the fix/parser-api branch August 18, 2023 12:27
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.2.0-next-major-spec.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants