Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add info and dependant models #485

Merged
merged 5 commits into from
Mar 9, 2022

Conversation

smoya
Copy link
Member

@smoya smoya commented Mar 8, 2022

Description

This PR adds Info and the dependant models (Contact, License). It also allows to retrieve Info from the document root.
The models are based on the new Intent API (even though Info looks the same by now).

Pending things that can be out of this PR:

  • How to handle retrocompatibility.

Related issue(s)
#482

src/models/asyncapi.ts Outdated Show resolved Hide resolved
src/models/info.ts Outdated Show resolved Hide resolved
@magicmatatjahu
Copy link
Member

@smoya I know that it's feature, but I prefer to add chore or refactor to not trigger release. In the react-component any feat or fix triggers release and we will publish first prerelease of 2.0.0 probably in next 2-3 months, so...

@derberg Maybe you wanna add something how we should annotate PRs for next-major.

smoya and others added 2 commits March 9, 2022 11:06
Co-authored-by: Maciej Urbańczyk <[email protected]>
Co-authored-by: Maciej Urbańczyk <[email protected]>
@derberg
Copy link
Member

derberg commented Mar 9, 2022

@magicmatatjahu sorry I didn't get it why it can't be released as release candidate? what react component has to do here?

@magicmatatjahu
Copy link
Member

@derberg due to the fact that in react component the first dozen of PRs were not released because the component itself did not work. Each PR was a new component rewritten to make PR easier. It is the same here. So the first PRs on next-major should not be released, because nothing works yet and it will work maybe in 2 weeks or a month. Of course I wanna release next-major as prerelease but not now.

@derberg
Copy link
Member

derberg commented Mar 9, 2022

@magicmatatjahu oh, ok, now it makes sense. I did not review this PR so was not aware what is the status. I totally agree that every release should include "working code", same with prereleases, something that can actually be used and integrated

@magicmatatjahu
Copy link
Member

@derberg No worries :)

@smoya So I suggest to use refactor for first PRs, ok?

@smoya smoya changed the title feat: add info and dependant models refactor: add info and dependant models Mar 9, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smoya
Copy link
Member Author

smoya commented Mar 9, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit d3d0a3e into asyncapi:next-major Mar 9, 2022
@smoya smoya deleted the feat/models branch March 9, 2022 15:05
magicmatatjahu pushed a commit to magicmatatjahu/parser-js that referenced this pull request Oct 3, 2022
derberg pushed a commit that referenced this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants