Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: init parse, lint and validate functions #487

Merged
merged 4 commits into from
Mar 9, 2022
Merged

refactor: init parse, lint and validate functions #487

merged 4 commits into from
Mar 9, 2022

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented Mar 9, 2022 •
edited
Loading

Description

  • add parse function:
    • init function's logic
    • add needed types
    • add relevant unit tests - simple, in next PRs I will add more complex cases
  • Add lint function:
    • init function's logic
    • add needed types
    • add relevant unit tests - simple, in next PRs I will add more complex cases
  • Add validate function:
    • init function's logic
    • add needed types
    • add relevant unit tests - simple, in next PRs I will add more complex cases
    • base validation on spectral 🚀

NOTE: lint and validate differ in that lint only returns errors, while validate also returns (or not, based on passed options) a validated object.

Related issue(s)
Part of #482

@magicmatatjahu magicmatatjahu added the enhancement New feature or request label Mar 9, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

smoya
smoya approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 136a632 into asyncapi:next-major Mar 9, 2022
@magicmatatjahu magicmatatjahu deleted the next/init-parse-function branch March 9, 2022 17:05
magicmatatjahu added a commit to magicmatatjahu/parser-js that referenced this pull request Oct 3, 2022
@magicmatatjahu
refactor: init parse, lint and validate functions (asyncapi#487)
e3809c0
derberg pushed a commit that referenced this pull request Oct 4, 2022
@magicmatatjahu @derberg
refactor: init parse, lint and validate functions (#487)
24a6eea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoya smoya smoya approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas is a code owner

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni jonaslagoni is a code owner

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magicmatatjahu @smoya @asyncapi-bot