Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken package-lock.json #531

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Conversation

smoya
Copy link
Member

@smoya smoya commented Apr 21, 2022

Description

A malformed package-lock.json file has been merged on https:/asyncapi/parser-js/pull/476/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519R63.

We didn't realize it until it was merged. See https:/asyncapi/parser-js/runs/6110565450?check_suite_focus=true
I think the whole set of github actions didn't run on the PR, maybe due to the fact it was the first time the author made a PR (and owner had to approve, but didn't happen).

Anyway, this PR is fixing it.

@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can happen indeed when there is no branch protection ensuring the jobs must go through. Same with at least one review, i.e. I could merge this one right now, and so can you by using /rtm as it does not require anything.
billede

Going forward with next-spec and next-major-spec this will be avoided as we no longer create branches as we go and no need to keep updating branch protection rules.

@derberg I dont have permission to change the branch protection, so you would need to do it, or give me permissions 😄

@smoya
Copy link
Member Author

smoya commented Apr 21, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit a71fecc into asyncapi:2022-04-release Apr 21, 2022
@smoya smoya deleted the fix/deps branch April 21, 2022 11:41
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.15.0-2022-04-release.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants