refactor: add SecurityRequirement(s) models #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoya
requested review from
fmvilas,
magicmatatjahu,
jonaslagoni,
derberg and
asyncapi-bot-eve
as code owners
smoya
commented
Aug 31, 2022
src/models/v2/server.ts
Outdated
| } | ||
| const scheme = this.createModel(SecurityScheme, securitySchemes[security], { id: security, pointer: `/components/securitySchemes/${security}` }); | ||
| requirements.push( | ||
| this.createModel(SecurityRequirement, scopes, { id: security, scheme: scheme, pointer: `` }) // TODO pointer?? |
There was a problem hiding this comment.
Not sure which pointer should be here as we don't know if the object is under components or not. cc @magicmatatjahu any idea?
src/models/v2/operation-trait.ts
Outdated
| } | ||
| const scheme = this.createModel(SecurityScheme, securitySchemes[security], { id: security, pointer: `/components/securitySchemes/${security}` }); | ||
| requirements.push( | ||
| this.createModel(SecurityRequirement, scopes, { id: security, scheme: scheme, pointer: `` }) // TODO pointer?? |
There was a problem hiding this comment.
Pointer for SecurityRequirement should be as (example):
/channels/{channel}/{operation}/security/{index of requirements}/{security variable - name of security schemes}
Why? Because we point to a single scheme of a single security requirement :) I hope this is clear. Let me know of any misunderstandings!
smoya
force-pushed
the
feat/securityRequirements
branch
from
03c49d7
to
ac8a428
Compare
smoya
force-pushed
the
feat/securityRequirements
branch
from
ac8a428
to
70f75e9
Compare
smoya
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
|
/rtm |
magicmatatjahu
pushed a commit
to magicmatatjahu/parser-js
that referenced
this pull request
Oct 3, 2022
derberg
pushed a commit
that referenced
this pull request
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the models for
SecurityRequirementandSecurityRequirementsbased on asyncapi/parser-api#71.Related issue(s)
#482