-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add binding validation #239
Merged
asyncapi-bot
merged 18 commits into
asyncapi:next-major-spec
from
jonaslagoni:feature/version_example_for_bindings
Feb 1, 2023
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
8c2fc11
added versioning
jonaslagoni 69bdfda
add rest of the bindings
jonaslagoni 63b0593
Merge branch 'next-major-spec' into feature/version_example_for_bindings
jonaslagoni 30b5b20
Merge branch 'master-github-upstream' into feature/version_example_fo…
jonaslagoni 3992b0d
Merge branch 'next-major-spec' into feature/version_example_for_bindings
jonaslagoni f599332
add solace version 0.3.0 bindings
jonaslagoni 2ad0256
add codeowners for bindings schemas as bindings repo layed out
jonaslagoni 7a93242
add google pubsub bindings
jonaslagoni 969bc39
add kafka 0.3.0 bindings
jonaslagoni f6a0eb0
add new bindings to 3.0.0 definition
jonaslagoni 466c2e5
fixed remaining bundle errors
jonaslagoni ccb5fcd
added ajv as dependency
jonaslagoni 495e0ef
Merge branch 'feature/update_next_major_spec_with_master' into featur…
jonaslagoni aba9e3c
fixed tests
jonaslagoni c390741
Merge branch 'next-major-spec' into feature/version_example_for_bindings
jonaslagoni fb960ee
add pulsar binding
jonaslagoni e9bfe13
fixed pattern property for pulsar
jonaslagoni da2dc5e
update spec generation
jonaslagoni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
bindings/amqp/message.json → bindings/amqp/0.2.0/message.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
bindings/amqp/operation.json → bindings/amqp/0.2.0/operation.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
bindings/anypointmq/channel.json → bindings/anypointmq/0.0.1/channel.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
bindings/anypointmq/message.json → bindings/anypointmq/0.0.1/message.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "$id": "http://asyncapi.com/bindings/googlepubsub/0.1.0/channel.json", | ||
| "title": "Cloud Pub/Sub Channel Schema", | ||
| "description": "This object contains information about the channel representation for Google Cloud Pub/Sub.", | ||
| "type": "object", | ||
| "additionalProperties": false, | ||
| "patternProperties": { | ||
| "^x-[\\w\\d\\.\\x2d_]+$": { | ||
| "$ref": "http://asyncapi.com/definitions/3.0.0/specificationExtension.json" | ||
| } | ||
| }, | ||
| "properties": { | ||
| "bindingVersion": { | ||
| "type": "string", | ||
| "enum": [ | ||
| "0.1.0" | ||
| ], | ||
| "description": "The version of this binding." | ||
| }, | ||
| "labels": { | ||
| "type": "object" | ||
| }, | ||
| "messageRetentionDuration": { | ||
| "type": "string" | ||
| }, | ||
| "messageStoragePolicy": { | ||
| "type": "object", | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "allowedPersistenceRegions": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "string" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "schemaSettings": { | ||
| "type": "object", | ||
| "additionalItems": false, | ||
| "properties": { | ||
| "encoding": { | ||
| "type": "string" | ||
| }, | ||
| "firstRevisionId": { | ||
| "type": "string" | ||
| }, | ||
| "lastRevisionId": { | ||
| "type": "string" | ||
| }, | ||
| "name": { | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "encoding", | ||
| "name" | ||
| ] | ||
| }, | ||
| "topic": { | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "schemaSettings", | ||
| "topic" | ||
| ], | ||
| "examples": [ | ||
| { | ||
| "labels": { | ||
| "label1": "value1", | ||
| "label2": "value2" | ||
| }, | ||
| "messageRetentionDuration": "86400s", | ||
| "messageStoragePolicy": { | ||
| "allowedPersistenceRegions": [ | ||
| "us-central1", | ||
| "us-east1" | ||
| ] | ||
| }, | ||
| "schemaSettings": { | ||
| "encoding": "json", | ||
| "name": "projects/your-project-id/schemas/your-schema" | ||
| } | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "$id": "http://asyncapi.com/bindings/googlepubsub/0.1.0/message.json", | ||
| "title": "Cloud Pub/Sub Channel Schema", | ||
| "description": "This object contains information about the message representation for Google Cloud Pub/Sub.", | ||
| "type": "object", | ||
| "additionalProperties": false, | ||
| "patternProperties": { | ||
| "^x-[\\w\\d\\.\\x2d_]+$": { | ||
| "$ref": "http://asyncapi.com/definitions/3.0.0/specificationExtension.json" | ||
| } | ||
| }, | ||
| "properties": { | ||
| "bindingVersion": { | ||
| "type": "string", | ||
| "enum": [ | ||
| "0.1.0" | ||
| ], | ||
| "description": "The version of this binding." | ||
| }, | ||
| "attributes": { | ||
| "type": "object" | ||
| }, | ||
| "orderingKey": { | ||
| "type": "string" | ||
| }, | ||
| "schema": { | ||
| "type": "object", | ||
| "additionalItems": false, | ||
| "properties": { | ||
| "name": { | ||
| "type": "string" | ||
| }, | ||
| "type": { | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "required": ["name", "type"] | ||
| } | ||
| }, | ||
| "examples": [ | ||
| { | ||
| "schema": { | ||
| "name": "projects/your-project-id/schemas/your-avro-schema-id", | ||
| "type": "avro" | ||
| } | ||
| }, | ||
| { | ||
| "schema": { | ||
| "name": "projects/your-project-id/schemas/your-protobuf-schema-id", | ||
| "type": "protobuf" | ||
| } | ||
| } | ||
| ] | ||
| } |
8 changes: 4 additions & 4 deletions
8
bindings/http/message.json → bindings/http/0.1.0/message.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
bindings/ibmmq/channel.json → bindings/ibmmq/0.1.0/channel.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
bindings/ibmmq/message.json → bindings/ibmmq/0.1.0/message.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
bindings/ibmmq/server.json → bindings/ibmmq/0.1.0/server.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
bindings/kafka/message.json → bindings/kafka/0.1.0/message.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a friendly reminder, you will need to invite all as contributors once it's fully merged 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also ping these maintainers in asyncapi/bindings#113 so they are aware 🙏🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do once merged 👍