Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: release for version 2.4.0 of the spec #740

Merged
merged 10 commits into from
Apr 27, 2022
Merged

Conversation

smoya
Copy link
Member

@smoya smoya commented Mar 21, 2022

This PR is created upfront to reflect on a daily basis what things are included in the release.

Also, the reason to create this PR a long time before the release is to enable automation (bot keeps upstream branches always up to date with master, see this action) that we have in place to regularly update the release branch with whatever is changed in the master branch. So nobody has to do it manually.

@smoya
Copy link
Member Author

smoya commented Mar 21, 2022

/dnm

@smoya
Copy link
Member Author

smoya commented Apr 13, 2022

/help

@asyncapi-bot
Copy link
Contributor

Hello, @smoya! 👋🏼

I'm Genie from the magic lamp. Looks like somebody needs a hand! 🆘

At the moment the following comments are supported in pull requests:

  • /ready-to-merge or /rtm - This comment will trigger automerge of PR in case all required checks are green, approvals in place and do-not-merge label is not added
  • /do-not-merge or /dnm - This comment will block automerging even if all conditions are met and ready-to-merge label is added
  • /autoupdate or /au - This comment will add autoupdate label to the PR and keeps your PR up-to-date to the target branch's future changes. Unless there is a merge conflict.

@smoya
Copy link
Member Author

smoya commented Apr 13, 2022

/au

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@smoya
Copy link
Member Author

smoya commented Apr 27, 2022

For the record: This branch had conflicts because we did squash when merging instead of simple (and no fast-forward) merge on #772. That's the reason we also see a lot of content on this PR that is already in master branch, because the merge commit is lost, so there is a new commit with no relation with parents in master branch, even though the content is the same. Related Stack Overflow: https://stackoverflow.com/questions/54636294/github-pr-squash-causes-erroneous-merge-conflicts.
I will open an issue after the release.

@smoya
Copy link
Member Author

smoya commented Apr 27, 2022

@dalelane @derberg @fmvilas We need your approval here so we can merge once asyncapi/spec-json-schemas#185 and asyncapi/parser-js#501 are merged

Copy link
Collaborator

@dalelane dalelane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@magicmatatjahu
Copy link
Member

@fmvilas Please approve.

@derberg
Copy link
Member

derberg commented Apr 27, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 65d5869 into master Apr 27, 2022
@asyncapi-bot asyncapi-bot deleted the 2022-04-release branch April 27, 2022 13:56
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants