Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add .prettierignore to prevent autoformatting #1934

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

vishvamsinh28
Copy link
Contributor

In this pr I have added .prettierignore which disables the code formatter for this project.

Fixes #1933

@netlify
Copy link

netlify bot commented Jul 12, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 31d2d62
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/64b01c0a41343c00089350fb
😎 Deploy Preview https://deploy-preview-1934--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Jul 12, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 41
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1934--asyncapi-website.netlify.app/

@derberg
Copy link
Member

derberg commented Jul 12, 2023

.prettierignore

nifty, wasn't aware of it, @akshatnema what do you think?

Copy link
Member

nifty, wasn't aware of it, @akshatnema what do you think?

I think, if lots of people facing the error, let's fix it out regarding prettier instead of defining prettierignore file for it. Because it takes same effort in having prettierignore and prettierrc file.

@derberg
Copy link
Member

derberg commented Jul 12, 2023

@akshatnema yeah but difference is that . prettierignore you just created and that is it, done. In case of prettierrc we all suddenly have to agree to use prettier to, maintain configuration, have contrib guide updated. So I do not think it is the same effort. My understanding is that once we create . prettierignore and long term finally provide proper eslint settings, we will no longer have autoformatters issues, or?

@akshatnema
Copy link
Member

My understanding is that once we create . prettierignore and long term finally provide proper eslint settings, we will no longer have autoformatters issues

Yeah, we will not have autoformatters issues again in the repository. Although it is not a good practice, but later on with proper discussion with community, we can add .prettierrc in the repository.

@derberg
Copy link
Member

derberg commented Jul 13, 2023

@akshatnema but I'm only referring to prettier, to block it for now.

have a look at #1640 (comment)

@vishvamsinh28
Copy link
Contributor Author

Yes exactly, their are other code formatters but most of developers use prettier and unknowingly they it makes unwanted changes in the PR so why don't we just ignore the whole thing with .prettierignore

@akshatnema
Copy link
Member

@akshatnema but I'm only referring to prettier, to block it for now.

Yeah, it will only block prettier, but a developer can use other code formatters inside IDE also.

@akshatnema
Copy link
Member

have a look at #1640 (comment)

If you wish to have .vscode file inside the package to define the correct extensions with appropriate configuration, we can then discuss it in detail in new issue. For now, with the current scope of the PR, we are eliminating the changes made by prettier.

@vishvamsinh28
Copy link
Contributor Author

vishvamsinh28 commented Jul 13, 2023

@akshatnema I have added .prettierignore for code editors!

@derberg
Copy link
Member

derberg commented Jul 13, 2023

For now, with the current scope of the PR, we are eliminating the changes made by prettier.

@akshatnema does it mean you accept the change or? 😄

@akshatnema
Copy link
Member

Yeah, I accept the changes 😄

@derberg derberg changed the title fix: added prettierignore fix: add .prettierignore to prevent autoformatting Jul 13, 2023
@derberg derberg requested a review from Mayaleeeee as a code owner July 13, 2023 15:45
@derberg
Copy link
Member

derberg commented Jul 13, 2023

/rtm

👋🏼 good bye unexpected quotation changes or semi-colons additions 😄

@asyncapi-bot asyncapi-bot merged commit 11ca5c1 into asyncapi:master Jul 13, 2023
17 checks passed
@derberg
Copy link
Member

derberg commented Jul 13, 2023

@allcontributors please add @vishvamsinh28 for code

@allcontributors
Copy link
Contributor

@derberg

I've put up a pull request to add @vishvamsinh28! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disable code formatter
4 participants