Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed the Responsiveness issue on Github button #3216

Closed
wants to merge 2 commits into from

Conversation

hkv24
Copy link
Contributor

@hkv24 hkv24 commented Sep 11, 2024

Description
This PR addresses the inconsistency of the button at '/tools/generator' route.

Screenshot

Screenshot 2024-09-11 at 7 12 16 PM

Fixes #3008

Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 51a708a
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/66e332247b7d06000898da00
😎 Deploy Preview https://deploy-preview-3216--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Sep 11, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 42
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3216--asyncapi-website.netlify.app/

@sambhavgupta0705
Copy link
Member

sambhavgupta0705 commented Sep 12, 2024

image

It hasn't been updated in this PR

@hkv24
Copy link
Contributor Author

hkv24 commented Sep 12, 2024

image

It has been updated in this PR

Just confirming, are you talking about my PR? If not, can you please mention the PR in which it is updated

@sambhavgupta0705
Copy link
Member

Mybad wrote a wrong comment

The preview is not working properly the button is still not aligned properly

@hkv24
Copy link
Contributor Author

hkv24 commented Sep 13, 2024

Mybad wrote a wrong comment

The preview is not working properly the button is still not aligned properly

Do you want margin between the 2 buttons?

@hkv24
Copy link
Contributor Author

hkv24 commented Sep 13, 2024

I have tried to fix it by giving it proper width.
You can look at this PR(#3230 ) 058cf59

@sambhavgupta0705
Copy link
Member

closing this as duplicate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Responsiveness issue on the View on Github button
3 participants