Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed allignment #3290

Closed
wants to merge 1 commit into from
Closed

fixed allignment #3290

wants to merge 1 commit into from

Conversation

nissu99
Copy link

@nissu99 nissu99 commented Oct 12, 2024

Description
fixed the allignment

  • ...
    Screenshot from 2024-10-12 12-46-57

  • ...

  • ...

Related issue(s)
Resolves #3281

Summary by CodeRabbit

  • New Features

    • Updated the rendering of the Calendar component in the community section for improved layout.
  • Bug Fixes

    • Removed unnecessary styling from the Calendar component, which may enhance consistency in appearance.
  • Documentation

    • Updated comment in the TypeScript configuration file to reference a more specific URL for guidance.

Copy link

coderabbitai bot commented Oct 12, 2024

Walkthrough

The changes in this pull request include an update to a comment in the next-env.d.ts file to provide a more specific URL for TypeScript configuration in Next.js. Additionally, the HomePage component in pages/[lang]/index.tsx has been modified by removing the className prop from the Calendar component, which may affect its styling without altering its functionality.

Changes

File(s) Change Summary
next-env.d.ts Updated comment to reference a specific URL for TypeScript configuration.
pages/[lang]/index.tsx Removed className prop from Calendar component in HomePage, potentially affecting styling.

Assessment against linked issues

Objective Addressed Explanation
Align 'Join our public meetings' text with 'Upcoming events' box (#3281) The changes do not address the alignment issue.

🐰 In the garden where bunnies play,
A Calendar's style has changed today.
No more float, just simple and neat,
Hop along, let’s make it sweet!
With updates bright, we’ll find our way,
To align our meetings, come what may! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between d744a0d and 9788256.

📒 Files selected for processing (2)
  • next-env.d.ts (1 hunks)
  • pages/[lang]/index.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • next-env.d.ts
🧰 Additional context used
🔇 Additional comments (1)
pages/[lang]/index.tsx (1)

111-111: Verify layout after removing float-left class

The removal of the className='float-left' prop from the Calendar component appears to be an attempt to address the alignment issue mentioned in the PR objectives. While this change might improve the alignment between the 'Upcoming events' box and the 'Join our public meetings' text, it could potentially affect the layout in unexpected ways.

Please verify the following:

  1. The alignment issue is indeed resolved across all screen sizes.
  2. The layout of the Calendar component and its surrounding elements remains correct on various device widths.

If the layout is not satisfactory after this change, consider alternative styling approaches, such as:

  • Using flexbox or grid layout to control the positioning
  • Adding custom classes or inline styles to achieve the desired alignment

To assist with verification, you can run the following commands to check the usage of the Calendar component across the codebase:

This will help ensure that the change doesn't negatively impact other parts of the codebase and that the alignment issue is properly resolved.

✅ Verification successful

Layout Verified After Removing float-left Class

The removal of the className='float-left' prop from the Calendar component in pages/[lang]/index.tsx has been verified. This change is isolated to the specified file and does not affect other parts of the codebase.

  • Confirmed that only pages/[lang]/index.tsx had the float-left class removed from the Calendar component.
  • Verified that float-left usage elsewhere (e.g., components/Figure.tsx) does not impact the Calendar component.
  • Ensured that the alignment issue between the 'Upcoming events' box and the 'Join our public meetings' text is resolved without introducing new layout problems.
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for Calendar component usage
echo "Calendar component usage:"
rg --type tsx "Calendar" -C 5

# Search for any float-left classes that might be affected
echo "\nfloat-left class usage:"
rg --type tsx "float-left"

Length of output: 234


Script:

#!/bin/bash
# Search for Calendar component usage in .tsx files
echo "Calendar component usage:"
rg "Calendar" --glob "*.tsx" -C 5

# Search for any float-left classes in .tsx files
echo "\nfloat-left class usage:"
rg "float-left" --glob "*.tsx"

Length of output: 17989


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Oct 12, 2024

We require all PRs to follow Conventional Commits specification.
More details 👇🏼

 No release type found in pull request title "fixed allignment". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Copy link

netlify bot commented Oct 12, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9788256
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/670a24f43a70e700083b7240
😎 Deploy Preview https://deploy-preview-3290--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 43
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3290--asyncapi-website.netlify.app/

@devilkiller-ag
Copy link
Member

Hi @nissu99, this issue is already being fixed in #3276.

@devilkiller-ag
Copy link
Member

devilkiller-ag commented Oct 12, 2024

Hi @nissu99, this issue is already being fixed in #3276. The issue #3281 was already created before in #3275. You are welcome to work on some other issues. I am closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] UI Alignment: Misalignment between 'Upcoming events' and 'Join our public meetings
3 participants