-
-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add brand guidelines pages #539
Conversation
Styles to match new brand have been added in tailwind config. In the process of making sure all typography and colors match new brand.
✔️ Deploy Preview for asyncapi-website ready! 🔨 Explore the source changes: de87941 🔍 Inspect the deploy log: https://app.netlify.com/sites/asyncapi-website/deploys/61dc813c14fc690008205c58 😎 Browse the preview: https://deploy-preview-539--asyncapi-website.netlify.app |
A piece of early feedback: I think the website looks "too pink" now and almost all the shades of pink are the same, removing effect from call-to-action buttons and the logo too. |
@fmvilas It's PURPLE come on now 😆 but I think I agree that we can change up some of the class names so there's not too much purple everywhere. This is mostly what happened after just changing the shades in the tailwind file. Not sure what you are seeing when you say the shades are almost all the same? Attached is a visual of the color palette so we can discuss! But also, comments might be better kept in this PR where the styles have been applied. This PR is only for the brand guidelines. |
It was too pink! 😂 😝 |
Agreed! The other PR for the updated styles on the website has been updated with the new "purple" that is a bit more muted and I changed the usage so it is used more as an accent color. This PR will have to be updated with those changes. Here is the deploy preview for that PR: https://deploy-preview-534--asyncapi-website.netlify.app/ Hoping that this is better! |
🤩 This is looking great and also good to focus points !! I have a question @mcturco |
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Description
This new posts page layout (based off of the Docs Layout) is aimed at guiding contributors when making website changes/enhancements.
Goals of the brand guidelines:
Over time, these pages will be edited and added to as our design systems progress in the future. For now, it is something to reference for basic usage of brand styles to make sure that everything is looking cohesive.
Note: Please don't merge until #534 is complete, and vice versa. This branch was built from a copy of the new styles PR branch.
Related issue(s)
Resolves #532