-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code cleaning on sdx_controller/messaging subfolder #249
Comments
@italovalcy Thank you for raising this. I agree, that code should be refactored and simplified. I think these are the steps we should take:
Broadly, I think we just need a If done right, we can reuse the final |
into the 'datamodel' repo? transformed to be the 'sdx-base'? just a thought. |
Not sure. We should do the refactoring first, and then evaluate if we need a library at all. |
As discussed on PR #223 (#223 (comment)) there is opportunity to review the code under
sdx_controller/messaging
subfolder and remove unused code. I'm opening this issue here so we can discuss this and see if it makes sense or not to keep the code there.Cc'ing @congwang09, @YufengXin and @sajith to provide comments.
The text was updated successfully, but these errors were encountered: