refactor(gov): remove usage of v1.ValidatorGovInfo #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbruyelle
requested review from
giunatale,
jaekwon and
adam-hanna
as code owners
adam-hanna
approved these changes
Sep 4, 2024
giunatale
approved these changes
Sep 10, 2024
tbruyelle
changed the base branch from
adam-hanna/gov/disable-vote-inheritance
to
main
This type was used to hold the validator vote and its delegation deductions. Now that vote inheritance is disabled, we don't need to hold these values any more, we can just use the type returned by the staking keeper.
tbruyelle
force-pushed
the
tbruyelle/refactor/tally
branch
from
2488ea2
to
d25dc9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type was used to hold the validator vote and its delegation
deductions. Now that vote inheritance is disabled, we don't need to hold
these values any more, we can just use the type returned by the staking
keeper.