Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/gov): remove No With Veto, and set default pass threshold to 2/3 and quorum to 25% #9

Merged
merged 5 commits into from
Sep 17, 2024

Conversation

giunatale
Copy link
Collaborator

  • Removes NWV Option
  • Sets default pass threshold to 2/3 (more precisely 0.667)
  • Sets default quorum to 25%

Changing the default params was pretty straightforward so I did it alongside the NWV removal

Copy link
Collaborator

@tbruyelle tbruyelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there's a couple of "no_with_veto" strings that still live in other places than v1beta1, for instance in the client package.
Search for that specific string and you will find them.

@giunatale
Copy link
Collaborator Author

giunatale commented Sep 13, 2024

EDIT: sorry, misunderstood. Will get to it

Copy link
Collaborator

@tbruyelle tbruyelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giunatale giunatale merged commit 184eee4 into main Sep 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants