Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webMUSHRA doesn't work correctly on Chrome >= 70 #26

Closed
faroit opened this issue Feb 14, 2018 · 11 comments
Closed

webMUSHRA doesn't work correctly on Chrome >= 70 #26

faroit opened this issue Feb 14, 2018 · 11 comments
Assignees
Labels

Comments

@faroit
Copy link
Collaborator

faroit commented Feb 14, 2018

Lets have this in mind and check if we are affected:
https://bugs.chromium.org/p/chromium/issues/detail?id=807017

@faroit
Copy link
Collaborator Author

faroit commented Mar 1, 2018

version 66 is now in the Dev channel. Can someone test it using chrome 66? @mschoeffler @aladami

@faroit
Copy link
Collaborator Author

faroit commented Apr 20, 2018

Chrome 66 was released and I just checked: webMUSHRA is affected by this change.
In clear text: webMUSHRA does not work anymore with Chrome!

@mschoeffler do you have time to fix it?
If not, I would propose to either put a warning in the readme or deprecate webMUSHRA entirely.

@faroit faroit added bug and removed config labels Apr 20, 2018
@faroit faroit changed the title Upcoming WebAudio Api changes in Chrome webMUSHRA doesn't work on Chrome 66 Apr 20, 2018
@faroit
Copy link
Collaborator Author

faroit commented Apr 25, 2018

@mschoeffler I've added a warning on the readme.md. 88b6c89

@faroit
Copy link
Collaborator Author

faroit commented Apr 27, 2018

ping @mschoeffler

@faroit
Copy link
Collaborator Author

faroit commented Apr 29, 2018

I don't know what exactly has changed in Chrome but it works fine now in 66.0.3359.139

@faroit faroit closed this as completed Apr 29, 2018
@faroit faroit reopened this May 14, 2018
@faroit
Copy link
Collaborator Author

faroit commented May 14, 2018

stopped working again in Chrome 66.0.3359.170...

@mschoeffler

@faroit faroit changed the title webMUSHRA doesn't work on Chrome 66 webMUSHRA doesn't work on Chrome 70 Aug 10, 2018
@faroit
Copy link
Collaborator Author

faroit commented Aug 10, 2018

Note: The Web Audio API will be included in the Chrome autoplay policy with M70 (October 2018).

new autoplay policy will break webmushra again

@faroit
Copy link
Collaborator Author

faroit commented Oct 4, 2018

The Web Audio API will be included in the Chrome autoplay policy with M71 (December 2018).

we need to address this soon

@lgestin
Copy link

lgestin commented May 10, 2019

Adding

document.addEventListener("click", function() {
    if (audioContext.state !== 'running') {
        audioContext.resume();
    }
}, true);

in startup.js fixes the issue for me.

@faroit
Copy link
Collaborator Author

faroit commented May 28, 2019

@lgestin looks like a working workaround, thanks. Can you add a PR?

@faroit faroit changed the title webMUSHRA doesn't work on Chrome 70 webMUSHRA doesn't work correctly on Chrome >= 70 May 20, 2020
@faroit
Copy link
Collaborator Author

faroit commented May 20, 2020

@lgestin in case this is still a recommended workaround, can you open a PR for this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants