Support for spatial attributes #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis CI fails... I'll have a look within the next days. |
don't worry this is node.js package manager issue, nothing to do with your code. I'll will fix that |
faroit
requested changes
Jun 7, 2017
configs/spatial.yaml
Outdated
| # bezierInnerRight: [299,50,100] | ||
| # bezierOuterRight: [200,50,50] | ||
| # height: 100 | ||
| # depth: 50 |
configs/spatial.yaml
Outdated
| views: | ||
| - view: front | ||
| - view: top | ||
| # - view: 3d |
| @@ -0,0 +1,17 @@ | |||
| /************************************************************************* | |||
| (C) Copyright AudioLabs 2015 | |||
| @@ -0,0 +1,15 @@ | |||
| /************************************************************************* | |||
| (C) Copyright AudioLabs 2015 | |||
| @@ -0,0 +1,12 @@ | |||
| /************************************************************************* | |||
| (C) Copyright AudioLabs 2015 | |||
| * Returns a hash map with values to save. | ||
| */ | ||
| ASWObject.prototype.storeValues = function(_trial, _session, _trial_id) { | ||
| // var trial = this.session.getTrial(this.pageConfig.type, this.pageConfig.id); |
| @@ -0,0 +1,383 @@ | |||
| /************************************************************************* | |||
| (C) Copyright AudioLabs 2015 | |||
| * Returns a hash map with values to save. | ||
| */ | ||
| LEVObject.prototype.storeValues = function(_trial, _session, _trial_id) { | ||
| // var trial = this.session.getTrial(this.pageConfig.type, this.pageConfig.id); |
| @@ -0,0 +1,73 @@ | |||
| /************************************************************************* | |||
| (C) Copyright AudioLabs 2015 | |||
| @@ -0,0 +1,36 @@ | |||
| /************************************************************************* | |||
| (C) Copyright AudioLabs 2015 | |||
faroit
reviewed
Jun 8, 2017
There was a problem hiding this comment.
looks good. Can you also bump up the version in https:/audiolabs/webMUSHRA/blob/master/package.json#L4 to 1.4.0 since this is a major new feature?
faroit
approved these changes
Jun 8, 2017
|
Looks good to merge. I will fix the travis error tomorrow |
|
travis magically fixed itself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature described in #17