Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Docker #21

Merged
merged 2 commits into from
Oct 18, 2017
Merged

Support Docker #21

merged 2 commits into from
Oct 18, 2017

Conversation

faroit
Copy link
Collaborator

@faroit faroit commented Oct 7, 2017

This adds docker configuration files. Using docker users can setup webMUSHRA within seconds without any further webserver configuration on Mac, Windows and Linux.

Please test on windows

@faroit faroit changed the title add docker installation Support Docker Oct 7, 2017
@aladami
Copy link
Collaborator

aladami commented Oct 10, 2017

For windows, the statement $env:COMPOSE_CONVERT_WINDOWS_PATHS=1 has to be added to account for windows path names.

Since also additionally steps are necessary to make it work on windows (Win7+ Docker Toolbox) than simply executing the stated command lines, this should be mentioned explicitly by means of a step-by-step explaination in the documentation.

@faroit
Copy link
Collaborator Author

faroit commented Oct 10, 2017

I think that it's not our job to document how to use docker. Maybe we just add a that Docker for Windows requires Windows 10 Pro?

@aladami
Copy link
Collaborator

aladami commented Oct 11, 2017

I think that it's not our job to document how to use docker.

You may be right, but isn't one the reasons for providing a docker configuation to make the setup of webMushra easier for people who are not so proficient with all the tools? I am sure, people will appreciate it.
Besides that it may also incease the number of users, when you do not have to spend hours to find out how to get things to work.

Maybe we just add a that Docker for Windows requires Windows 10 Pro

This would be possible, provided that there are not the same issues. I did/could not test that.

@faroit
Copy link
Collaborator Author

faroit commented Oct 11, 2017

okay, I've added a Docker on Windows note to the readme

@faroit faroit merged commit 1736e6f into master Oct 18, 2017
@faroit faroit deleted the docker branch October 18, 2017 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants