-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This is an awesome project. I want to contribute :-) #104
Comments
My repository ready to Pull Request. |
hey, yes i saw it. I will try to rebase my fork and changes on your branch i guess. One question - I try to add dependencies from You seem to have edited
If you want to see my current progress, it's here: https:/serapath-contribution/clmtrackr |
Just figured out, that the original The library has a network where I am not sure what is the most up2date version, see: Maybe it's worth making a fork and publishing it to
I know i would like to |
@serapath My last commit not atomic. changes in Changes in Since the Declaration of the method "self.onmessage" moved to a function, changed method of function call.
Initialize single worker
Retain callback before each call, since it is impossible to bring in a Worker |
I just don't understand why were included unsupported project. |
my fork is still "Work in Progress". I would like to remove I checked all forks and found two which had changes not included in the main Can you take a look at:
UPDATE: oh, i just saw, that those authors actually made pull requests which are the only ones still open: I just tried to reach out to the author on twitter https://twitter.com/serapath/status/863139445184225280 If they don't respond, maybe it's possible to fork If you agree with this approach I would do that after waiting for maybe 1 day or so for the author to respond. |
Hello auduno.
Luckily it's possible to open issues on this repository. Most forks don't allow this.
I just checked the "network" of the repo and i found the following very recently active forks:
Both authors seem to be after the same thing. Better module support, so that it would work nicely as a commonjs dependency in other projects.
In the last days I was working on a very large and serious refactoring of the code base.
I did not touch the core parts at all, because i honestly don't have a clue how this module is doing what it's doing, but it's good at it :-)
The "refactoring" might be a bit too massive to be an ok pull request so i might just publish it as it's own module. ...but then again, i would like to receive future updates and it would be a little bit of maintenance work to always pull the latest features into my fork so i was wondering if you would be open in theory to merge such a serious refactoring.
I would also be willing to adapt my changes to make them "mergable" if you want.
The text was updated successfully, but these errors were encountered: