Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build pipeline #486

Closed
JacoKoster opened this issue Jun 8, 2018 · 3 comments
Closed

Build pipeline #486

JacoKoster opened this issue Jun 8, 2018 · 3 comments

Comments

@JacoKoster
Copy link
Contributor

JacoKoster commented Jun 8, 2018

I have already

I'd like to add two more things to make working on this repository a little bit easier

  • change the jshint-config to a eslint-config
  • change travis configuration to the following buildsteps (and change the package.json accordingly)
  1. test
  2. coverage
  3. nsp
  4. lint

Would this be a good idea to do?

@ziluvatar
Copy link
Contributor

change the jshint-config to a eslint-config

Ok with that. Do you mean to keep both or to remove the jshint?

change travis configuration to the following buildsteps...

Ok. Do you mean to modify the current test script in package.json and remove from there test + coverage + nsp + cost-of-modules and create build steps for them in travis?

About the order, probably it is better to set the lint as first step because it is faster to get a failure and avoid waiting for tests to pass to then get an error from the linter.

@JacoKoster
Copy link
Contributor Author

JacoKoster commented Jun 19, 2018

I fully endorse #490 as a way to solve this, i will add another PR to make sure the build breaks when the code-coverage is below a certain threshold.

That would change the order (indeed) to lint - test (with blocking coverage-check) - nsp

@JacoKoster
Copy link
Contributor Author

I am considering this one finished, thanks @MitMaro and @ziluvatar :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants