Implement async/sync tests for nbf claim #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the existing tests for the nbf claim to use the async/sync test helpers. This required fixing a case where an error was improperly handled for an async call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #492
This implements the test helpers introduced in #523 for the nbf claim.
There was one test case that required a code change. When the not before is provided using an empty string, the error is thrown synchronously during an asynchronous call. This error is already triggered by another error (#499) and similar to #536, so I believe it is okay to fix the handling of this error even if it is a slight behaviour change.
Coverage Master
Coverage Branch