Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to Java 11 #1

Closed
wants to merge 2 commits into from
Closed

switch to Java 11 #1

wants to merge 2 commits into from

Conversation

rPraml
Copy link

@rPraml rPraml commented Apr 29, 2022

Some tools (like eclipse https://bugs.eclipse.org/bugs/show_bug.cgi?id=536273 ) cannot detect the module-info.class in META-INF/versions/9.
I think it would be a good idea to switch here completely to java 11.
(Note: multiple PRs will follow)

@rPraml
Copy link
Author

rPraml commented Apr 29, 2022

Please wait. I think we run in a never ending story here, as other multi-version-jars (like fasterxml) will have similar problems

@rPraml
Copy link
Author

rPraml commented May 2, 2022

@rbygrave FYI: This bug is reported here: https://bugs.eclipse.org/bugs/show_bug.cgi?id=577790

We currently use the eclipse compiler (ecj) in nearly all of our projects as it supports multi-threading and is almost twice as fast as javac. And it behaves exactly the same as in eclipse. (There are some code places, where the javac expects excplicit casts, while ecj does not)

We do not use JPMS, yet, but we intend to use it. We are also seriously considering moving from Eclipse/Ecj to IntelliJ/Javac due to the issues I've seen over the past few weeks...

You may accept or close this PR - This change is no longer necessary from our side.

@rbygrave
Copy link
Contributor

rbygrave commented May 2, 2022

Ok, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants