Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the correct address space on functions #68

Closed
dylanmckay opened this issue Jul 9, 2017 · 2 comments
Closed

Use the correct address space on functions #68

dylanmckay opened this issue Jul 9, 2017 · 2 comments

Comments

@dylanmckay
Copy link
Member

dylanmckay commented Jul 9, 2017 •
edited
Loading

All functions currently which live in address space zero, meaning RAM, but they actually reside inside program memory.

We need to fix this, so that in #65 we can properly select the fixup type from the address space.
@dylanmckay
Copy link
Member Author

Obligatory patch

@dylanmckay dylanmckay mentioned this issue Aug 23, 2017
Closed
@dylanmckay dylanmckay changed the title Use the correct address space on all values Use the correct address space on functions Aug 23, 2017
@dylanmckay dylanmckay mentioned this issue Aug 23, 2017
Closed
@dylanmckay
Copy link
Member Author

Since landed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dylanmckay