feat: Have an ability to configure session name #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Configure roleSessionName with role-session-name from action or default value (GitHubActions)
cychiang
changed the title
cychiang
changed the title
action.yml
Outdated
| @@ -25,6 +25,9 @@ inputs: | |||
| role-duration-seconds: | |||
| description: "Role duration in seconds (default: 6 hours)" | |||
| required: false | |||
| role-session-name: | |||
| description: 'Role Session Name (default: GitHubActions)' | |||
There was a problem hiding this comment.
Nit:
Suggested change
| description: 'Role Session Name (default: GitHubActions)' | |
| description: 'Role session name (default: GitHubActions)' |
There was a problem hiding this comment.
No problem! I have updated the code based on your suggestions. The test code is ready and looks good, let me know if need more improvements. 😄
clareliguori
approved these changes
Mar 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I submit this PR for an ability to configure role session name after assuming a role with
configure-aws-credentialsActions.The story behind this PR is, recently, AWS has released a new feature for IAM - "CalledVia." It's a cool feature and no need to give extra write permissions to people to create stacks with CloudFormation. Now, we are changing our way of working by integrating GitHub Actions to deploy CloudFormation templates, but also want to know who update templates by using AWS CloudTrail.
We figure out the CloudTrail will take session name as user name. Therefore we want to have a configurable session name to tag meaningful information on it instead of GitHubActions.