fix: add nonScalarFields and arrayFields to schemas with mapped names #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use non-mapped table name to generate array/non-scalar fields on relational queries ✅ Closes: #2581
update snapshots for graphql-name-mapping-transformer
add tests to ensure array/non-scalar fields are properly set on relational objects
phani-srikar
approved these changes
Jul 3, 2024
dpilch
approved these changes
Jul 3, 2024
palpatim
deleted the
kekami-graphql-relational-transformer/fix-non-scalar-fields
branch
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The relevant commits in this PR are from cherry picked from @kekami, as first proposed in #2627
This PR resolves merge conflicts and provides a base for verifying with E2E tests.
Issue #, if available
#2581
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.