Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move Gen-1 API plugin to LTS branch #2744

Merged
merged 9 commits into from
Aug 19, 2024
Merged

Conversation

phani-srikar
Copy link
Contributor

@phani-srikar phani-srikar commented Aug 6, 2024

Description of changes

Removes the following Gen-1 related packages:

  • amplify-category-api
  • amplify-util-mock
  • amplify-dynamodb-simulator
  • amplify-graphql-transformer-migrator
  • amplify-schema-validator (owned by Console team and used in Gen-1 flows)
  • several V1 transformer packages

Bumps the major version for packages common to LTS branch and main including the V2 transformers. The new major version will have active feature development going forward.
Verified that version bumps are as expected:
Screenshot 2024-08-16 at 3 21 07 PM

Test updates:

  • Remove the V1 transformer migration tests
  • Remove the V1 transformer directives' E2E tests

CI updates:

  • Remove the mock-e2e-tests job
  • Update the split-e2e-tests script and re-generate the E2E workflow codebuild spec.

Due to the volume of changes, this PR mostly has only package, test deletions which can be seen better from the left-side file navigation view during review. The follow-up PR would have the changes necessary to bump the version of transformer packages common to Gen-1 and CDK/Data constructs.

CDK / CloudFormation Parameters Changed

Issue #, if available

Description of how you validated changes

Full E2E test run passes except following - sql_iam_access, rds_pg_field_auth_userpool_iam, sql_pg_models and RelationalWithAuthV2Redacted. These are due to unrelated test issues like account hitting resource limits. Re-trying and investigating some.

Verified using local publish via verdaccio and consuming the updated package version in amplify-backend repo that I'm able to build and run unit tests.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Any CDK or CloudFormation parameter changes are called out explicitly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phani-srikar phani-srikar changed the base branch from main to main-without-gen1-plugin-staging August 8, 2024 22:17
@phani-srikar phani-srikar marked this pull request as ready for review August 8, 2024 22:29
@phani-srikar phani-srikar requested review from a team as code owners August 8, 2024 22:29
sobolk
sobolk previously approved these changes Aug 8, 2024
Copy link
Member

@sobolk sobolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@phani-srikar phani-srikar changed the base branch from main-without-gen1-plugin-staging to main August 16, 2024 14:13
@phani-srikar phani-srikar dismissed sobolk’s stale review August 16, 2024 14:13

The base branch was changed.

@phani-srikar phani-srikar changed the base branch from main to main-without-gen1-plugin-staging August 16, 2024 15:07
BREAKING CHANGE: distinguish from LTS version
@phani-srikar phani-srikar changed the base branch from main-without-gen1-plugin-staging to main August 16, 2024 23:12
@phani-srikar phani-srikar merged commit 8448067 into main Aug 19, 2024
6 of 7 checks passed
@phani-srikar phani-srikar deleted the move-gen1-api-plugin branch August 19, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants