fix: change gen 1 patterns to warning message instead of error #2768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpilch
commented
Aug 13, 2024
| @@ -153,6 +153,12 @@ export class PredictionsTransformer extends TransformerPluginBase { | |||
| }; | |||
|
|
|||
| generateResolvers = (context: TransformerContextProvider): void => { | |||
| // This validation can't occur in validate because the api has not been initialized until generateResolvers | |||
| if (!context.transformParameters.allowGen1Patterns) { | |||
| cdk.Annotations.of(context.api).addWarning( | |||
There was a problem hiding this comment.
Annotations also has addDeprecation. I chose to use addWarning here because addDeprecation appears to be geared towards deprecating an entire parameter. We are removing some functionality from a parameter.
dpilch
changed the title
palpatim
previously approved these changes
Aug 13, 2024
palpatim
approved these changes
Aug 19, 2024
phani-srikar
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
_allowGen1Patternsfrom the translation behavior config and always disallow gen 1 patterns in the construct. Gen 1 patterns will always be allowed in Gen 1.CDK / CloudFormation Parameters Changed
_allowGen1Patternsfrom the translation behavior config and always disallow gen 1 patterns in the construct.Issue #, if available
N/A
Description of how you validated changes
N/A
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.