docs(contributing): ✏️ require node v18.x #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update CONTRIBUTING.md to specify Node version v18.x. yarn && yarn build && yarn test yields "error [email protected]: The engine "node" is incompatible with this module. Expected version ">= 18.12.0". Got "16.20.2"" on Node version v16.x
palpatim
approved these changes
Aug 22, 2024
dpilch
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update CONTRIBUTING.md to specify Node version v18.x.
yarn && yarn build && yarn testyieldserror [email protected]: The engine "node" is incompatible with this module. Expected version ">= 18.12.0". Got "16.20.2"on Node version v16.xCDK / CloudFormation Parameters Changed
n/a
Issue #, if available
n/a
Description of how you validated changes
ran this by @phani-srikar
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.