Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump cdk dependency to ^1.159.0 #873

Merged
merged 3 commits into from
Oct 13, 2022
Merged

Conversation

AaronZyLee
Copy link
Contributor

Description of changes

This PR is a re-draft of #591 as the PR was out of sync with main for some time.

CLI has updated the CDK dependencies to ^1.159.0. The API needs to bump the version as well to reduce amount of the packaged CLI binary.

CLI commit: aws-amplify/amplify-cli@52c1e49

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AaronZyLee AaronZyLee requested a review from a team as a code owner October 12, 2022 20:59
Copy link
Contributor

@phani-srikar phani-srikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if the e2e failures in the PR checks are related? Thanks

@codecov-commenter
Copy link

Codecov Report

Merging #873 (a9ec719) into main (e9bf292) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #873   +/-   ##
=======================================
  Coverage   63.30%   63.30%           
=======================================
  Files         282      282           
  Lines       18377    18377           
  Branches     4461     4461           
=======================================
  Hits        11634    11634           
  Misses       6132     6132           
  Partials      611      611           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants