Cross account support for V2 function transformer and directive #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 1 alert when merging f773765 into a928809 - view on LGTM.com fixed alerts:
|
alharris-at
previously approved these changes
Nov 9, 2022
|
This pull request fixes 1 alert when merging dc8b9f1 into a928809 - view on LGTM.com fixed alerts:
|
phani-srikar
force-pushed
the
cross-account-function-directive
branch
from
dc8b9f1
to
96f32b5
Compare
|
This pull request fixes 1 alert when merging 96f32b5 into a928809 - view on LGTM.com fixed alerts:
|
phani-srikar
changed the title
alharris-at
previously approved these changes
Nov 10, 2022
AaronZyLee
previously approved these changes
Nov 11, 2022
packages/graphql-transformers-e2e-tests/src/__tests__/FunctionTransformerTestsV2.e2e.test.ts
Show resolved
Hide resolved
packages/graphql-transformers-e2e-tests/src/__tests__/FunctionTransformerTestsV2.e2e.test.ts
Outdated
Show resolved
Hide resolved
packages/graphql-transformers-e2e-tests/src/__tests__/FunctionTransformerTestsV2.e2e.test.ts
Outdated
Show resolved
Hide resolved
packages/graphql-transformers-e2e-tests/src/__tests__/FunctionTransformerTestsV2.e2e.test.ts
Outdated
Show resolved
Hide resolved
phani-srikar
dismissed stale reviews from AaronZyLee and alharris-at
via
7f07935
Codecov Report
@@ Coverage Diff @@
## main #975 +/- ##
==========================================
+ Coverage 63.14% 63.32% +0.17%
==========================================
Files 278 282 +4
Lines 18125 18376 +251
Branches 4375 4460 +85
==========================================
+ Hits 11445 11636 +191
- Misses 6093 6130 +37
- Partials 587 610 +23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AaronZyLee
previously approved these changes
Nov 11, 2022
alharris-at
previously approved these changes
Nov 14, 2022
| @@ -2,12 +2,12 @@ import { simplifyName } from './util'; | |||
| import md5 from 'md5'; | |||
|
|
|||
| export class FunctionResourceIDs { | |||
| static FunctionDataSourceID(name: string, region?: string): string { | |||
| return `${simplifyName(name)}${simplifyName(region || '')}LambdaDataSource`; | |||
| static FunctionDataSourceID(name: string, region?: string, accountId?:string): string { | |||
There was a problem hiding this comment.
n.p. on spacing after the colon here, and in the next few functions as well.
phani-srikar
dismissed stale reviews from alharris-at and AaronZyLee
via
b216bbb
alharris-at
approved these changes
Nov 14, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR is an extension of #639 with the following changes:
In Summary, with these changes, customers can use the newly added
accountIdinput to@functiondirective to attach lambda functions that are maintained in different AWS account and are managed independently.Issue #, if available
Description of how you validated changes
Unit testing
Added e2e tests
In a JS sample app
Full e2e pipeline run
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.