feat(storage): multi bucket list api #5576
Open
+107
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* exported UnmetPasswordRequirements --------- Co-authored-by: Jose Alba <[email protected]> Co-authored-by: Elijah Quartey <[email protected]>
* chore(infra): bumped dset versions
…AuthOutputs instead of Auth config (#5456)
…mplify/amplify-flutter into feat/multi-bucket-list-api
ekjotmultani
changed the title
Equartey
reviewed
Oct 21, 2024
| @@ -27,8 +28,11 @@ class StorageListOptions | |||
| /// {@macro amplify_core.storage.list_plugin_options} | |||
| final StorageListPluginOptions? pluginOptions; | |||
|
|
|||
| /// an optional bucket to specify which bucket to return the list for | |||
There was a problem hiding this comment.
nit: make this consistent with the getProperties api doc
| setUpAll(() async { | ||
| await configure(amplifyEnvironments['main']!); | ||
|
|
||
| for (final path in uploadedPaths) { | ||
| for (var i = 0; i < 4; i++) { |
There was a problem hiding this comment.
Q: Why did this change? Regardless, the upper bound for all these for loops should not be magic numbers. Please move these to descriptive variable names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
added storage bucket option to the options type for the list api
added integration tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.