Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: changeset/actions minor fixes #595

Merged
merged 4 commits into from
Oct 29, 2021
Merged

ci: changeset/actions minor fixes #595

merged 4 commits into from
Oct 29, 2021

Conversation

wlee221
Copy link
Contributor

@wlee221 wlee221 commented Oct 29, 2021

Issue #, if available:

Description of changes:

  • Add @changesets/changelog-github utility, as this is needed for creating changelogs.
  • Correct the script name to "Publish to latest"
  • Don't build the packages (yet) for main, as we aren't publishing yet. We just need to generate the PR for now.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2021

⚠️ No Changeset found

Latest commit: 95253ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wlee221 wlee221 temporarily deployed to ci October 29, 2021 18:51 Inactive
@wlee221 wlee221 temporarily deployed to ci October 29, 2021 18:51 Inactive
@wlee221 wlee221 temporarily deployed to ci October 29, 2021 18:51 Inactive
@wlee221 wlee221 temporarily deployed to ci October 29, 2021 19:14 Inactive
@wlee221 wlee221 temporarily deployed to ci October 29, 2021 19:14 Inactive
@wlee221 wlee221 temporarily deployed to ci October 29, 2021 19:14 Inactive
@wlee221 wlee221 merged commit 671da74 into main Oct 29, 2021
@wlee221 wlee221 deleted the changeset-minor-fixes branch October 29, 2021 20:44
thaddmt added a commit that referenced this pull request Apr 7, 2023
* fix(android/firefox): adjust streaming video size for testing (#593)

Co-authored-by: Heather Buchel <[email protected]>

* fix: iPad video constraints and device detection  (#594)

* Test for mobile device

* fix ipad detection, move to utils

Co-authored-by: Heather Buchel <[email protected]>

* Ipad safari (#595)

fix: update detection for ipad so it passes the isIOS check

* fix: update freshness color canvas to 100% width and height (#596)

* fix: livenessIconWithPopver to original

Co-authored-by: Heather Buchel <[email protected]>
Co-authored-by: Heather Buchel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants