Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist & scroll to anchor when changing frameworks #776

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Persist & scroll to anchor when changing frameworks #776

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions docs/src/components/Layout/FrameworkChooser.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,27 @@ export const FrameworkChooser = ({ platform }) => {
const router = useRouter();

const chooseFramework = (framework) => {
router.replace({
pathname: router.pathname,
query: { platform: framework },
});
const { hash } = window.location;

router.replace(
{
hash,
pathname: router.pathname,
query: { platform: framework },
},
// `as?` prop isn't needed when URL is already provided
undefined,
{
// Scroll to top if a new page
scroll: hash ? false : true,
}
);

// Because layout may change, explicitly tell the browser to scroll to that anchor
// e.g. <a id="#variation" />
if (hash) {
document.getElementById(hash.slice(1)).scrollIntoView();
}
};

return (
Expand Down