feat: Add DynamoDB provider to parameters module #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehouel
reviewed
Mar 16, 2023
...-parameters/src/main/java/software/amazon/lambda/powertools/parameters/DynamoDBProvider.java
Outdated
Show resolved
Hide resolved
scottgerring
commented
Mar 16, 2023
...-parameters/src/main/java/software/amazon/lambda/powertools/parameters/DynamoDBProvider.java
Outdated
Show resolved
Hide resolved
stevehouel
reviewed
Mar 17, 2023
...-parameters/src/main/java/software/amazon/lambda/powertools/parameters/DynamoDbProvider.java
Show resolved
Hide resolved
scottgerring
changed the title
scottgerring
commented
Mar 17, 2023
scottgerring
commented
Mar 17, 2023
...-parameters/src/main/java/software/amazon/lambda/powertools/parameters/DynamoDbProvider.java
Show resolved
Hide resolved
scottgerring
commented
Mar 17, 2023
.../src/test/java/software/amazon/lambda/powertools/parameters/ParamManagerIntegrationTest.java
Show resolved
Hide resolved
scottgerring
commented
Mar 17, 2023
...ameters/src/test/java/software/amazon/lambda/powertools/parameters/DynamoDbProviderTest.java
Show resolved
Hide resolved
scottgerring
changed the title
jeromevdl
reviewed
Mar 17, 2023
jeromevdl
reviewed
Mar 17, 2023
...ters/src/test/java/software/amazon/lambda/powertools/parameters/DynamoDbProviderE2ETest.java
Show resolved
Hide resolved
jeromevdl
reviewed
Mar 17, 2023
...ameters/src/test/java/software/amazon/lambda/powertools/parameters/DynamoDbProviderTest.java
Outdated
Show resolved
Hide resolved
jeromevdl
reviewed
Mar 17, 2023
...ameters/src/test/java/software/amazon/lambda/powertools/parameters/DynamoDbProviderTest.java
Show resolved
Hide resolved
jeromevdl
reviewed
Mar 17, 2023
| .item(responseData) | ||
| .build()); | ||
| // Act | ||
| Assertions.assertThrows(NullPointerException.class, () -> { |
There was a problem hiding this comment.
Are you sure it should be nullpointer? Couldn't we have a better (eventually custom) one?
There was a problem hiding this comment.
Throwing a DynamoDbProviderSchemaException now with the error text describing the missing column
|
@jeromevdl I think that should be it! I've cleaned up the exceptions too. |
|
@jeromevdl anything else to polish? 👼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1083
Description of changes:
Adds a
DynamoDbProviderto the parameters module. Follows the style of the existing parameters provider and the schema used in the python powertools.Checklist
Breaking change checklist
N/A - new functionality
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.