Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add maintainers guide #1326

Merged
merged 17 commits into from
Jul 31, 2023
Merged

docs: Add maintainers guide #1326

merged 17 commits into from
Jul 31, 2023

Conversation

scottgerring
Copy link
Contributor

@scottgerring scottgerring commented Jul 28, 2023 •
edited
Loading

Issue #, if available:
#1295

Description of changes:

Adds a maintainers guide to the documentation site, inspired by python's maintainers playbook.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@scottgerring scottgerring changed the title doc: Add maintainers guide docs: Add maintainers guide Jul 28, 2023
@scottgerring scottgerring marked this pull request as ready for review July 28, 2023 13:11
sthulb
sthulb approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@sthulb sthulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is much improved

@scottgerring @jeromevdl
Update docs/processes/maintainers.md
402f472 
Co-authored-by: Jérôme Van Der Linden <[email protected]>
jeromevdl
jeromevdl suggested changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few changes and it's ok

@scottgerring
Copy link
Contributor Author

@jeromevdl should be good now!

@jeromevdl jeromevdl merged commit 70da5f0 into main Jul 31, 2023
2 checks passed
@jeromevdl jeromevdl deleted the doc-improvements branch July 31, 2023 09:23
@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sthulb sthulb sthulb approved these changes

@jeromevdl jeromevdl jeromevdl approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottgerring @sthulb @jeromevdl