chore: remove aspectj-rt from the library

[jeromevdl]

Issue #, if available: #1401

Description of changes:

• remove aspectj-rt from the library itself => requires to add it in the project that uses powertools, but at least developers can choose their version and are not stick to 1.9.7 which does not work anymore with java 17.
• update example to simplify the configuration (just set the aspectj version in the profile and keep the same plugin configuration). If we remove java8, we can remove the profile (default version of aspectj is 1.9.20)

Checklist

• Meet tenets criteria
• Update tests
• Update docs ==> not yet
• PR title follows conventional commit semantics

Breaking change checklist

requires the developers to add to their pom

        <dependency>
            <groupId>org.aspectj</groupId>
            <artifactId>aspectjrt</artifactId>
            <version>...</version> <!-- 1.9.7 for java 8 or higher otherwise -->
        </dependency>

RFC issue #:

• Migration process documented ==> not yet
• Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[jeromevdl]

@roamingthings, what do you think about it?

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (v2@b5135c9). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files

@@          Coverage Diff          @@
##             v2    #1408   +/-   ##
=====================================
  Coverage      ?   77.17%           
  Complexity    ?      522           
=====================================
  Files         ?       64           
  Lines         ?     2134           
  Branches      ?      223           
=====================================
  Hits          ?     1647           
  Misses        ?      415           
  Partials      ?       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[roamingthings]

The parent pom still uses 1.9.7 and I'm not sure if this would be treated as a transient dependency. I will try to do some testing.

[scottgerring]

I haven't had a chance to think about this in depth yet, but my initial reaction is:

requires to add it in the project that uses powertools

Where does this fall on the spectrum of breaking changes? We'd have to at the very least message this clearly in the release notes, as it is likely to break most client's builds when they roll their PT dep(s) forward.

[roamingthings]

as it is likely to break most client's builds when they roll their PT dep(s) forward

This relates to all project that don't use the AspectJ plugin.

[jeromevdl]

The parent pom still uses 1.9.7 and I'm not sure if this would be treated as a transient dependency. I will try to do some testing.

@roamingthings, the parent pom references it but no module actually uses it, and we still need it for our own code. And since we support java8 (until @scottgerring decides to leave it 😄), we need to keep the 1.9.7 version. But it should not be retrieved in your application. Actually you need to explicitly specify one version (1.9.20 most probably as of now). I didn't try with Gradle yet...

[roamingthings]

@jeromevdl

I didn't try with Gradle yet...

That's what I meant by

I will try to do some testing.

[roamingthings]

I can confirm that Gradle will no longer add aspectj-rt as transient dependency with this change 👍

[jeromevdl]

moving as draft, I want to merge main into v2 to get the gradle sample working with this

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[scottgerring]

LGTM. And I am super glad we have the E2E tests for this sort of thing.