Issue#820 - add new CDK example demonstrating AWS CodePipeline based CICD setup #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add lambdaApiStack
add ECS Fargate Stack Issue#820
Add DataStoreStack
…ions It create a SNS topic, a SQS queue, and a EventBridge rule that trigger asynchronous lambda functions. The source of event is the Amazon ECS events that are published into the default EventBridge event bus. We use this event to push messages to the SNS topic and to the SQS queue.
Modified a sample stack for asynchronous lambda function for aws-samples#820
Update README.md
|
Hi @kaiz-io, can you help to review the PR by any chance? thank you |
sebs
reviewed
Oct 14, 2024
| constructor(scope: Construct, id: string, props?: cdk.StackProps) { | ||
| super(scope, id, props); | ||
|
|
||
| const pipelineAccountId = process.env.PIPELINE_ACCOUNT_ID || "111111111111"; // replace with your pipeline account id |
There was a problem hiding this comment.
maybe use context, move receiving this to the code in /bin and get rid of the defaults?
that is for all .ENV code here
There was a problem hiding this comment.
updated as per suggestion on the commit id: #7cf8ea7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #820
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.