Avoid detaching EFA ENIs #1237
Merged
Avoid detaching EFA ENIs #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haouc
approved these changes
Sep 30, 2020
| @@ -1039,14 +1048,22 @@ func (cache *EC2InstanceMetadataCache) DescribeAllENIs() ([]ENIMetadata, map[str | |||
| if interfaceType == "trunk" { | |||
| trunkENI = eniID | |||
| } | |||
| if interfaceType == "efa" { | |||
There was a problem hiding this comment.
Can we consider to use switch/case to evaluate interfaceTypes?
There was a problem hiding this comment.
If we get a third custom interface type, I think it's about time to switch. 😀
jayanthvn
reviewed
Sep 30, 2020
mogren
force-pushed
the
avoid-deleting-efa
branch
from
154b898
to
7d8efac
Compare
jayanthvn
reviewed
Sep 30, 2020
mogren
force-pushed
the
avoid-deleting-efa
branch
from
7d8efac
to
365d10c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancement
What does this PR do / Why do we need it:
If we have an instance with EFA interfaces, we should make sure to never detach them.
Testing done on this change:
Added unit tests
Automation added to e2e:
No new tests added. Passing e2e tests: https://app.circleci.com/pipelines/github/mogren/amazon-vpc-cni-k8s/1035/workflows/86d66e2b-d920-44a4-8c4c-10dd54aca78d/jobs/2082
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.