Update readme on stdout support for plugin log file #1251
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug
Which issue does this PR fix:
#1248
What does this PR do / Why do we need it:
This PR flags an error when
stdout
is set forAWS_VPC_K8S_PLUGIN_LOG_FILE
. Stdout cannot be used for redirecting plugin logs since the plugin expects the network configuration in JSON format must be streamed through stdin and output on success streamed back to stdout. Ref - https:/containernetworking/cni/blob/master/SPEC.md#resultIf an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Attached logs and analysis in #1248
Testing done on this change:
UT 1 -> if stdout is set as plugin log file
UT 2 - Setting stderr as plugin log file
Delete and add running pods -
UT 3 - Added interface type which will help during EFA debugging -
UT 4 - Uppercase of STDOUT
UT 5 - file name is uppercase, should be retained
Automation added to e2e:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
UT 6 - Upgrade 1.7.4 to 1.7.5
On upgrade -
Does this change require updates to the CNI daemonset config files to work?:
It will work with kubectl patch(ref UT 3)
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.