Adding additional CRD for Calico that was missing. #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 92b46e1)
|
What about globalfelixconfigs and globalbgpconfigs? |
|
Hmm, true, looks like they are missing as well. Should we make another PR for that? The comment from Casey on #406 says: "This looks right to me - should fix this issue: projectcalico/calico#2540" |
|
Yeah, either a new PR and cc them or ask them on that comment thread. |
tiffanyfay
approved these changes
Apr 25, 2019
|
@tiffanyfay Good catch btw, thanks for checking all resources. 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Cherry picked #406 to the release-1.4 branch.
(cherry picked from commit 92b46e1)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.