Error when newly required env var is missing #502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws@463e880 swapped discovery of local running pods from the docker daemon to the k8s API. In doing so it now requires the `MY_NODE_NAME` environment variable -- which was both (1) not documented and (2) no error if it is not set. In the case that the variable wasn't set the local daemon would then attempt to add *all* pods that aren't assigned to any node (as the node name would be ""). This patch (1) adds an entry in readme about this option and (2) returns an error if it is not set.
|
Hey @jacksontj, thanks for the PR, but there are multiple things to consider here. First of all, this environment variable should already have be set in the configuration and that should probably be documented. Also, it is currently fetched from the environment in two places which is weird, and there is no error handling if it's not set. I think this might need some more refactoring to resolve these issues, I'll try to get some time to go through it some more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
463e880 swapped discovery of local running pods from the docker daemon to the k8s API. In doing so it now requires the
MY_NODE_NAMEenvironment variable -- which was both (1) not documented and (2) no error if it is not set. In the case that the variable wasn't set the local daemon would then attempt to add all pods that aren't assigned to any node (as the node name would be "").This patch (1) adds an entry in readme about this option and (2) returns
an error if it is not set.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.