Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detach ENI before deleting #538

Merged
merged 1 commit into from
Jul 22, 2019
Merged

Conversation

uthark
Copy link
Contributor

@uthark uthark commented Jul 22, 2019

Fix for issue #537.

Try to detach ENI before deleting it.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mogren mogren self-requested a review July 22, 2019 18:18
@mogren mogren added this to the v1.6 milestone Jul 22, 2019
@mogren mogren added the bug label Jul 22, 2019
Copy link
Contributor

@mogren mogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @uthark for catching this. There are a lot of corner cases where throttling can put the data store in a bad state.

@mogren mogren merged commit 081539e into aws:master Jul 22, 2019
@uthark
Copy link
Contributor Author

uthark commented Jul 22, 2019

@mogren Is there any plans to release a minor 1.5.1 just with the bugfixes or do you plan to release 1.6.0 only?

@uthark uthark deleted the oatamanenko/detach-eni branch July 22, 2019 18:26
@mogren
Copy link
Contributor

mogren commented Jul 23, 2019

@uthark I would really like to get #371 merged first, just need a little more testing. So far everything looks good.

The top priority is to resolve #282, #330 and #525, which are all basically the same issue. So once we get those fixed I'll make a v1.6-rc build and start some more deep testing.

There is some work to get a new version out, but I'd prefer if we could be more frequent with new releases instead of trying to put too many things in before cutting the next one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants