Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick of fixes from master to the release-1.5 branch #581

Merged
merged 3 commits into from
Aug 8, 2019
Merged

Cherry pick of fixes from master to the release-1.5 branch #581

merged 3 commits into from
Aug 8, 2019

Conversation

mogren
Copy link
Contributor

@mogren mogren commented Aug 8, 2019

Claes Mogren and others added 3 commits August 7, 2019 17:58
Copy the binary and config after ipamd is ready
e1d127c 
(cherry picked from commit f9acdeb)
@lmm
Update deprecated apiVersions and fields
6a46286 
(cherry picked from commit a3045f8)
@jacksontj
Add env var to override introspection bind address
49a31cc 
2b08772 (inadvertently?) changed the
bind address from `:61678` to `localhost:61678` which is backwards
incompatible and for those actually scraping the metrics via prometheus
makes the metrics endpoint entirely unusable (since prometheus isn't
local to each node in the cluster).

This path simply adds an env var to override the bind address.

(cherry picked from commit 6176e35)
@mogren mogren requested a review from tiffanyfay August 8, 2019 01:03
@mogren mogren merged commit 62c6bc5 into aws:release-1.5 Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiffanyfay tiffanyfay tiffanyfay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mogren @tiffanyfay @lmm @jacksontj