-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cni-metrics-helper source code #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is binary cni-metrics-helper/cni-metrics-helper committed to source repo?
Bump can we please get this merged? Especially since pulling the image in misc/cni_metrics_helper.yaml results in an error. Thanks, |
Can we also have a clear description of IAM permissions needed to publish metrics to CW? Is having "cloudwatch:PutMetricData" enough? |
options.pullInterval, options.submitCW) | ||
|
||
var kubeClient clientset.Interface | ||
kubeClient, err = createKubeClient("", options.kubeconfig) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove the apiserver parameter from the createKubeClient function since it is only used in one place and you are providing a constant value of an empty string.
} | ||
|
||
// Get cloudwatch client | ||
ec2MetadataClient := ec2metadatawrapper.New(nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned on the declaration, the nil
parameter here isn't clean.
@@ -0,0 +1,68 @@ | |||
// Code generated by MockGen. DO NOT EDIT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see where this is used. I think it can be removed.
@vpm-bradleyhession we are still in the process of code reviewing. At meantime, you can checkout the source code of this PR and build it. |
@xdrus cloudwatch:PutMetricData IAM should be enough to publish cloudwatch metrics. Please let me know if you see any issues thanks |
Are there plans to move this forward or merge? My organization is exploring adopting EKS and we would like to have more insight and metrics into CNI. |
Closing this PR in favor of #413 |
*Issue #113 *
Description of changes:
cni-metrics-helper
The following show how cni-metrics-helper works in a cluster:
install cni-metrics-helper
kubectl apply -f misc/cni_metrics_helper.yaml
get cni-metrics-helper logs
cni-metrics-helper key log messages
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.