Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary/incorrect ClusterRole resource #883

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

anguslees
Copy link
Contributor

crd.k8s.amazonaws.com/namespaces does not exist, and even if it did
it would already be covered by crd.k8s.amazonaws.com/*. Looks like
an incorrect merge at some point.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

`crd.k8s.amazonaws.com/namespaces` does not exist, and even if it did
it would already be covered by `crd.k8s.amazonaws.com/*`.  Looks like
an incorrect merge at some point.
@anguslees anguslees requested a review from mogren March 25, 2020 03:39
Copy link
Contributor

@mogren mogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@jaypipes jaypipes merged commit 2b3a065 into aws:master Mar 25, 2020
@anguslees anguslees deleted the manifest branch March 30, 2020 04:47
ajayk added a commit to ajayk/eksctl that referenced this pull request Apr 7, 2020
mogren pushed a commit to mogren/amazon-vpc-cni-k8s that referenced this pull request Apr 20, 2020
`crd.k8s.amazonaws.com/namespaces` does not exist, and even if it did
it would already be covered by `crd.k8s.amazonaws.com/*`.  Looks like
an incorrect merge at some point.
mogren pushed a commit that referenced this pull request Apr 20, 2020
`crd.k8s.amazonaws.com/namespaces` does not exist, and even if it did
it would already be covered by `crd.k8s.amazonaws.com/*`.  Looks like
an incorrect merge at some point.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants