Skip to content

Commit

Permalink
chore(cloudformation): update integration tests with description para…
Browse files Browse the repository at this point in the history
…meter for custom resources (#13276)

Integration test in `core` module requires that any custom description parameter integration tests should be done in `cloudformation` module. 

https:/aws/aws-cdk/blob/master/packages/%40aws-cdk/core/test/integration.custom-resources.readme

```
+--------------------------------------------------------------------------+
| Since cdk-integ depends on cdk which depends on @aws-cdk/core (as a "dev |
| dependency"), this integration test has been added to the package        |
| @aws-cdk/aws-cloudformation under `test/integ.core-custom-resources.ts`  |
+--------------------------------------------------------------------------+
```

Depends on #13275

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
robertd authored Feb 25, 2021
1 parent 8712b40 commit 39ab806
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@
"Arn"
]
},
"Runtime": "nodejs12.x"
"Runtime": "nodejs12.x",
"Description": "veni vidi vici"
},
"DependsOn": [
"CustomReflectCustomResourceProviderRoleB4B29AEC"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ class TestStack extends Stack {
const serviceToken = CustomResourceProvider.getOrCreate(this, resourceType, {
codeDirectory: `${__dirname}/core-custom-resource-provider-fixture`,
runtime: CustomResourceProviderRuntime.NODEJS_12,
description: 'veni vidi vici',
});

const cr = new CustomResource(this, 'MyResource', {
Expand Down

0 comments on commit 39ab806

Please sign in to comment.