Merge branch 'master' into sns-subs-zero-numeric-filter

aws · Sep 27, 2021 · 4d393d6 · 4d393d6
2 parents 2a1ce3a + 851c8ca
commit 4d393d6
Show file tree

Hide file tree

Showing 427 changed files with 17,130 additions and 15,191 deletions.
diff --git a/.github/workflows/close-stale-issues.yml b/.github/workflows/close-stale-issues.yml
@@ -2,13 +2,16 @@ name: "Close Stale Issues"
 
 # Controls when the action will run.
 on:
+ workflow_dispatch:
  schedule:
  - cron: "0 6 * * *"
 
 jobs:
  cleanup:
  permissions:
  issues: write
+ contents: read
+ pull-requests: write
  runs-on: ubuntu-latest
  name: Stale issue job
  steps:
@@ -43,6 +46,6 @@ jobs:
  minimum-upvotes-to-exempt: 5
 
  repo-token: ${{ secrets.GITHUB_TOKEN }}
- # loglevel: DEBUG
+ loglevel: DEBUG
  # Set dry-run to true to not perform label or close actions.
  dry-run: false
diff --git a/.github/workflows/issue-label-assign.yml b/.github/workflows/issue-label-assign.yml
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,49 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https:/conventional-changelog/standard-version) for commit guidelines.
 
+## [1.124.0](https:/aws/aws-cdk/compare/v1.123.0...v1.124.0) (2021-09-21)
+
+
+### ⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES
+
+* **assertions:** the `findResources()` API previously returned a list of resources, but now returns a map of logical id to resource.
+* **assertions:** the `findOutputs()` API previously returned a list of outputs, but now returns a map of logical id to output.
+* **assertions:** the `findMappings()` API previously returned a list of mappings, but now returns a map of logical id to mapping.
+
+### Features
+
+* **assertions:** capture matching value ([#16426](https:/aws/aws-cdk/issues/16426)) ([cc74f92](https:/aws/aws-cdk/commit/cc74f92f275a338cb53caa7d6f124ab0dd960f0b))
+* **assertions:** findXxx() APIs now includes the logical id as part of its result ([#16454](https:/aws/aws-cdk/issues/16454)) ([532a72b](https:/aws/aws-cdk/commit/532a72b133e6ebd0c7b8b7c65b273bb0e6f3293c))
+* **assertions:** match into serialized json ([#16456](https:/aws/aws-cdk/issues/16456)) ([fed30fc](https:/aws/aws-cdk/commit/fed30fc815bac1006003524ac6232778f3c3babe))
+* **batch:** fargate support for jobs ([#15848](https:/aws/aws-cdk/issues/15848)) ([066bcb1](https:/aws/aws-cdk/commit/066bcb1e5d53192bd465190c8a4f81c5838987f4)), closes [#13591](https:/aws/aws-cdk/issues/13591) [#13590](https:/aws/aws-cdk/issues/13590) [#13591](https:/aws/aws-cdk/issues/13591)
+* **cfnspec:** cloudformation spec v41.1.0 ([#16472](https:/aws/aws-cdk/issues/16472)) ([28875f9](https:/aws/aws-cdk/commit/28875f9dda4911d3a2fcfcdc6e6d8358bee7c689))
+* **cfnspec:** cloudformation spec v41.1.0 ([#16524](https:/aws/aws-cdk/issues/16524)) ([124a7a1](https:/aws/aws-cdk/commit/124a7a1c20981c72bfdce0c857c87c46c6cb5f51))
+* **cfnspec:** cloudformation spec v41.2.0 ([#16550](https:/aws/aws-cdk/issues/16550)) ([e047bd8](https:/aws/aws-cdk/commit/e047bd80ab08f49a22408eb8c5401f4306747eff))
+* **ec2/ecs:** `cacheInContext` properties for machine images ([#16021](https:/aws/aws-cdk/issues/16021)) ([430f50a](https:/aws/aws-cdk/commit/430f50a546e9c575f8cdbd259367e440d985e68f)), closes [#12484](https:/aws/aws-cdk/issues/12484)
+* **ecs-service-extensions:** Publish Extension ([#16326](https:/aws/aws-cdk/issues/16326)) ([c6c5941](https:/aws/aws-cdk/commit/c6c594159c7fbda66f40fe8666f70b6806bb2d5e))
+* **glue:** Job construct ([#12506](https:/aws/aws-cdk/issues/12506)) ([fc74110](https:/aws/aws-cdk/commit/fc74110ff7eae544d9cfc11b2f6779169f17d145)), closes [#12443](https:/aws/aws-cdk/issues/12443)
+* **lambda:** configure workdir for docker image based functions ([#16111](https:/aws/aws-cdk/issues/16111)) ([b3eafc2](https:/aws/aws-cdk/commit/b3eafc2dc61ed69de20196fa08a4df3c29ecc894))
+* **lambda:** use bundling docker image from ECR public for dotnet and go runtimes ([#16281](https:/aws/aws-cdk/issues/16281)) ([9bbfd18](https:/aws/aws-cdk/commit/9bbfd185c2383612e2be7317a091b72cc5e7a120))
+* **neptune:** add engine version 1.0.5.0 ([#16394](https:/aws/aws-cdk/issues/16394)) ([deaac4a](https:/aws/aws-cdk/commit/deaac4a16e957bd046f24a6c26d735fc4cf980bd)), closes [#16388](https:/aws/aws-cdk/issues/16388)
+* **pipeline:** allow enabling KMS key rotation for cross-region Stacks ([#16468](https:/aws/aws-cdk/issues/16468)) ([2a629dd](https:/aws/aws-cdk/commit/2a629dd7a86cc36c3a503bfc5957880c9edd4d49)), closes [#14381](https:/aws/aws-cdk/issues/14381)
+* **rds:** region replication for generated secrets ([#16497](https:/aws/aws-cdk/issues/16497)) ([1e9d8be](https:/aws/aws-cdk/commit/1e9d8be0a81e1f875bf8b31c701e1069bb98728e)), closes [#16480](https:/aws/aws-cdk/issues/16480)
+* **redshift:** manage database users and tables via cdk ([#15931](https:/aws/aws-cdk/issues/15931)) ([a9d5118](https:/aws/aws-cdk/commit/a9d51185a144cd4962c85227ae5b904510399fa4)), closes [#9815](https:/aws/aws-cdk/issues/9815)
+* **s3-deployment:** enable efs support for handling large files in lambda ([#15220](https:/aws/aws-cdk/issues/15220)) ([2737119](https:/aws/aws-cdk/commit/27371197a24ce6c9212fc99e120c5d77fa08065e))
+* **sns:** adding support for firehose subscription protocol ([#15764](https:/aws/aws-cdk/issues/15764)) ([18aff6b](https:/aws/aws-cdk/commit/18aff6b4c0a5e17c64685ac384b243c16cd910f1))
+* **stepfunctions-tasks:** support Associate Workflow Executions on StepFunctionsStartExecution via associateWithParent property ([#16475](https:/aws/aws-cdk/issues/16475)) ([7d3b90b](https:/aws/aws-cdk/commit/7d3b90b2097aa9b7170a77befcee5822d5d0c3e7)), closes [#14778](https:/aws/aws-cdk/issues/14778)
+
+
+### Bug Fixes
+
+* **apigatewayv2:** ApiMapping does not depend on DomainName ([#16201](https:/aws/aws-cdk/issues/16201)) ([1e247d8](https:/aws/aws-cdk/commit/1e247d89adbc09ff79b87753fcd78b238a6752e8)), closes [#15464](https:/aws/aws-cdk/issues/15464)
+* **cloudformation-diff:** cdk diff not picking up differences if old/new value is in format n.n.n ([#16050](https:/aws/aws-cdk/issues/16050)) ([38426c9](https:/aws/aws-cdk/commit/38426c985d5e0713bbbf14fa639520eca6294124)), closes [#15935](https:/aws/aws-cdk/issues/15935)
+* **config:** the IGW mapping to correct resource type ([#16464](https:/aws/aws-cdk/issues/16464)) ([23d9b6a](https:/aws/aws-cdk/commit/23d9b6a7d5b213e4a1ba4a71984e8e19e3657bd7)), closes [#16463](https:/aws/aws-cdk/issues/16463)
+* **core:** asset hash of symlinked dir is wrong ([#16429](https:/aws/aws-cdk/issues/16429)) ([36ff738](https:/aws/aws-cdk/commit/36ff73809a37998e15176cb8815c118e7ea0c295))
+* **ec2:** set proper role for --role argument of cfn-init ([#16503](https:/aws/aws-cdk/issues/16503)) ([cdbd65d](https:/aws/aws-cdk/commit/cdbd65dc525147810650b4c32d48664a38abede1)), closes [#16501](https:/aws/aws-cdk/issues/16501)
+* **logs:** log retention fails with OperationAbortedException ([#16083](https:/aws/aws-cdk/issues/16083)) ([3e9f04d](https:/aws/aws-cdk/commit/3e9f04dbbd7aadb8ab4394fefd6281f1d6d30fe0)), closes [aws#15709](https:/aws/aws/issues/15709)
+* **route53resolver:** FirewallDomainList throws with wildcard domains ([#16538](https:/aws/aws-cdk/issues/16538)) ([643e5ee](https:/aws/aws-cdk/commit/643e5ee519095968a758942220f1e3a6c20f54b3)), closes [#16527](https:/aws/aws-cdk/issues/16527)
+* **SSM API docs:** Typo `SecretString` -> `SecureString` and note how SecureStrings cannot be created via CDK ([#16228](https:/aws/aws-cdk/issues/16228)) ([950e875](https:/aws/aws-cdk/commit/950e875bfb431c051b5ee2fd405aaf7f2b47bfeb))
+
 ## [1.123.0](https:/aws/aws-cdk/compare/v1.122.0...v1.123.0) (2021-09-16)
 
 

diff --git a/package.json b/package.json
@@ -29,9 +29,7 @@
  "standard-version": "^9.3.1",
  "typescript": "~3.9.10"
  },
- "tap-mocha-reporter-resolutions-comment": "should be removed or reviewed when nodeunit dependency is dropped or adjusted",
  "resolutions": {
- "tap-mocha-reporter": "^5.0.1",
  "string-width": "^4.2.2"
  },
  "repository": {

diff --git a/packages/@aws-cdk-containers/ecs-service-extensions/package.json b/packages/@aws-cdk-containers/ecs-service-extensions/package.json
@@ -36,9 +36,6 @@
  "organization": true
  },
  "license": "Apache-2.0",
- "cdk-build": {
- "jest": true
- },
  "devDependencies": {
  "@types/jest": "^26.0.24",
  "cdk-build-tools": "0.0.0",

diff --git a/packages/@aws-cdk/alexa-ask/package.json b/packages/@aws-cdk/alexa-ask/package.json
@@ -56,7 +56,6 @@
  },
  "cdk-build": {
  "cloudformation": "Alexa::ASK",
- "jest": true,
  "env": {
  "AWSLINT_BASE_CONSTRUCT": true
  }

diff --git a/packages/@aws-cdk/app-delivery/package.json b/packages/@aws-cdk/app-delivery/package.json
@@ -62,7 +62,6 @@
  "devDependencies": {
  "@aws-cdk/aws-s3": "0.0.0",
  "@types/jest": "^26.0.24",
- "@types/nodeunit": "^0.0.32",
  "cdk-build-tools": "0.0.0",
  "cdk-integ-tools": "0.0.0",
  "fast-check": "^2.17.0",
@@ -82,9 +81,6 @@
  "url": "https://aws.amazon.com",
  "organization": true
  },
- "cdk-build": {
- "jest": true
- },
  "keywords": [
  "aws",
  "cdk"

diff --git a/packages/@aws-cdk/assert-internal/package.json b/packages/@aws-cdk/assert-internal/package.json
@@ -57,9 +57,6 @@
  },
  "stability": "experimental",
  "maturity": "experimental",
- "cdk-build": {
- "jest": true
- },
  "publishConfig": {
  "tag": "latest"
  },

diff --git a/packages/@aws-cdk/assert/package.json b/packages/@aws-cdk/assert/package.json
@@ -17,7 +17,6 @@
  "build+test+extract": "yarn build+test"
  },
  "cdk-build": {
- "jest": true,
  "pre": [
  "./clone.sh"
  ],

diff --git a/packages/@aws-cdk/assertions/package.json b/packages/@aws-cdk/assertions/package.json
@@ -49,7 +49,6 @@
  "projectReferences": true
  },
  "cdk-build": {
- "jest": true,
  "pre": [
  "./vendor-in.sh"
  ]

diff --git a/packages/@aws-cdk/assets/package.json b/packages/@aws-cdk/assets/package.json
@@ -54,8 +54,7 @@
  "cdk-build": {
  "pre": [
  "rm -rf test/fs/fixtures && cd test/fs && tar -xzvf fixtures.tar.gz"
- ],
- "jest": true
+ ]
  },
  "keywords": [
  "aws",
@@ -79,7 +78,7 @@
  "pkglint": "0.0.0",
  "sinon": "^9.2.4",
  "ts-mock-imports": "^1.3.7",
- "@aws-cdk/assert-internal": "0.0.0"
+ "@aws-cdk/assertions": "0.0.0"
  },
  "dependencies": {
  "@aws-cdk/core": "0.0.0",

diff --git a/packages/@aws-cdk/assets/test/compat.test.ts b/packages/@aws-cdk/assets/test/compat.test.ts
@@ -1,5 +1,4 @@
 import { SymlinkFollowMode } from '@aws-cdk/core';
-import '@aws-cdk/assert-internal/jest';
 import { FollowMode } from '../lib';
 import { toSymlinkFollow } from '../lib/compat';
 

diff --git a/packages/@aws-cdk/assets/test/staging.test.ts b/packages/@aws-cdk/assets/test/staging.test.ts
@@ -2,7 +2,6 @@ import * as fs from 'fs';
 import * as path from 'path';
 import { App, Stack } from '@aws-cdk/core';
 import * as cxapi from '@aws-cdk/cx-api';
-import '@aws-cdk/assert-internal/jest';
 import { Staging } from '../lib';
 
 describe('staging', () => {

diff --git a/packages/@aws-cdk/aws-accessanalyzer/package.json b/packages/@aws-cdk/aws-accessanalyzer/package.json
@@ -56,7 +56,6 @@
  },
  "cdk-build": {
  "cloudformation": "AWS::AccessAnalyzer",
- "jest": true,
  "env": {
  "AWSLINT_BASE_CONSTRUCT": true
  }

diff --git a/packages/@aws-cdk/aws-acmpca/package.json b/packages/@aws-cdk/aws-acmpca/package.json
@@ -56,7 +56,6 @@
  },
  "cdk-build": {
  "cloudformation": "AWS::ACMPCA",
- "jest": true,
  "env": {
  "AWSLINT_BASE_CONSTRUCT": true
  }
@@ -79,7 +78,7 @@
  "cdk-build-tools": "0.0.0",
  "cfn2ts": "0.0.0",
  "pkglint": "0.0.0",
- "@aws-cdk/assert-internal": "0.0.0"
+ "@aws-cdk/assertions": "0.0.0"
  },
  "dependencies": {
  "@aws-cdk/core": "0.0.0",

diff --git a/packages/@aws-cdk/aws-acmpca/test/acmpca.test.ts b/packages/@aws-cdk/aws-acmpca/test/acmpca.test.ts
@@ -1,4 +1,3 @@
-import '@aws-cdk/assert-internal/jest';
 import {} from '../lib';
 
 test('No tests are specified for this package', () => {

diff --git a/packages/@aws-cdk/aws-amazonmq/package.json b/packages/@aws-cdk/aws-amazonmq/package.json
@@ -56,7 +56,6 @@
  },
  "cdk-build": {
  "cloudformation": "AWS::AmazonMQ",
- "jest": true,
  "env": {
  "AWSLINT_BASE_CONSTRUCT": true
  }

diff --git a/packages/@aws-cdk/aws-amplify/package.json b/packages/@aws-cdk/aws-amplify/package.json
@@ -56,7 +56,6 @@
  },
  "cdk-build": {
  "cloudformation": "AWS::Amplify",
- "jest": true,
  "env": {
  "AWSLINT_BASE_CONSTRUCT": true
  }

diff --git a/packages/@aws-cdk/aws-apigateway/package.json b/packages/@aws-cdk/aws-apigateway/package.json
@@ -57,8 +57,7 @@
  "cloudformation": "AWS::ApiGateway",
  "env": {
  "AWSLINT_BASE_CONSTRUCT": true
- },
- "jest": true
+ }
  },
  "keywords": [
  "aws",
@@ -323,6 +322,7 @@
  "attribute-tag:@aws-cdk/aws-apigateway.LambdaRestApi.restApiName",
  "from-method:@aws-cdk/aws-apigateway.Stage",
  "resource-attribute:@aws-cdk/aws-apigateway.ApiKey.apiKeyId",
+ "resource-attribute:@aws-cdk/aws-apigateway.GatewayResponse.gatewayResponseId",
  "resource-attribute:@aws-cdk/aws-apigateway.RateLimitedApiKey.apiKeyId"
  ]
  },

diff --git a/packages/@aws-cdk/aws-apigatewayv2-authorizers/package.json b/packages/@aws-cdk/aws-apigatewayv2-authorizers/package.json
@@ -55,7 +55,6 @@
  "build+test+extract": "yarn build+test && yarn rosetta:extract"
  },
  "cdk-build": {
- "jest": true,
  "env": {
  "AWSLINT_BASE_CONSTRUCT": true
  }

diff --git a/packages/@aws-cdk/aws-apigatewayv2-integrations/package.json b/packages/@aws-cdk/aws-apigatewayv2-integrations/package.json
@@ -53,7 +53,6 @@
  "build+test+extract": "yarn build+test && yarn rosetta:extract"
  },
  "cdk-build": {
- "jest": true,
  "env": {
  "AWSLINT_BASE_CONSTRUCT": true
  }

diff --git a/packages/@aws-cdk/aws-apigatewayv2/package.json b/packages/@aws-cdk/aws-apigatewayv2/package.json
@@ -60,7 +60,6 @@
  },
  "cdk-build": {
  "cloudformation": "AWS::ApiGatewayV2",
- "jest": true,
  "env": {
  "AWSLINT_BASE_CONSTRUCT": true
  }

diff --git a/packages/@aws-cdk/aws-appconfig/package.json b/packages/@aws-cdk/aws-appconfig/package.json
@@ -56,7 +56,6 @@
  },
  "cdk-build": {
  "cloudformation": "AWS::AppConfig",
- "jest": true,
  "env": {
  "AWSLINT_BASE_CONSTRUCT": true
  }

diff --git a/packages/@aws-cdk/aws-appflow/package.json b/packages/@aws-cdk/aws-appflow/package.json
@@ -55,8 +55,7 @@
  "build+test+extract": "yarn build+test && yarn rosetta:extract"
  },
  "cdk-build": {
- "cloudformation": "AWS::AppFlow",
- "jest": true
+ "cloudformation": "AWS::AppFlow"
  },
  "keywords": [
  "aws",

diff --git a/packages/@aws-cdk/aws-appintegrations/package.json b/packages/@aws-cdk/aws-appintegrations/package.json
@@ -58,7 +58,6 @@
  },
  "cdk-build": {
  "cloudformation": "AWS::AppIntegrations",
- "jest": true,
  "env": {
  "AWSLINT_BASE_CONSTRUCT": "true"
  }

diff --git a/packages/@aws-cdk/aws-applicationautoscaling/package.json b/packages/@aws-cdk/aws-applicationautoscaling/package.json
@@ -55,7 +55,6 @@
  },
  "cdk-build": {
  "cloudformation": "AWS::ApplicationAutoScaling",
- "jest": true,
  "env": {
  "AWSLINT_BASE_CONSTRUCT": true
  }

diff --git a/packages/@aws-cdk/aws-applicationinsights/package.json b/packages/@aws-cdk/aws-applicationinsights/package.json
@@ -56,7 +56,6 @@
  },
  "cdk-build": {
  "cloudformation": "AWS::ApplicationInsights",
- "jest": true,
  "env": {
  "AWSLINT_BASE_CONSTRUCT": true
  }

diff --git a/packages/@aws-cdk/aws-appmesh/package.json b/packages/@aws-cdk/aws-appmesh/package.json
@@ -58,8 +58,7 @@
  "cloudformation": "AWS::AppMesh",
  "env": {
  "AWSLINT_BASE_CONSTRUCT": true
- },
- "jest": true
+ }
  },
  "nyc": {
  "statements": 75