-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(elasticloadbalancingv2): cant set grpc code matcher on alb #13947
Labels
@aws-cdk/aws-elasticloadbalancingv2
Related to Amazon Elastic Load Balancing V2
feature-request
A feature should be added or improved.
needs-triage
This issue or PR still needs to be triaged.
Comments
ChristopheBougere
added
feature-request
A feature should be added or improved.
needs-triage
This issue or PR still needs to be triaged.
labels
Apr 1, 2021
github-actions
bot
added
the
@aws-cdk/aws-elasticloadbalancingv2
Related to Amazon Elastic Load Balancing V2
label
Apr 1, 2021
mergify bot
pushed a commit
that referenced
this issue
Apr 6, 2021
With #13570, it is now possible to set the protocol version for ALB target groups, and thus make it working for GRPC. However, it is not yet possible to define a GrpcCode for the matcher (see [CloudFormation doc](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-elasticloadbalancingv2-targetgroup-matcher.html)). I added a `healthyGrpcCodes` working the same way as `healthyHttpCodes`. closes #13947 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this issue
Aug 26, 2021
With aws#13570, it is now possible to set the protocol version for ALB target groups, and thus make it working for GRPC. However, it is not yet possible to define a GrpcCode for the matcher (see [CloudFormation doc](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-elasticloadbalancingv2-targetgroup-matcher.html)). I added a `healthyGrpcCodes` working the same way as `healthyHttpCodes`. closes aws#13947 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-elasticloadbalancingv2
Related to Amazon Elastic Load Balancing V2
feature-request
A feature should be added or improved.
needs-triage
This issue or PR still needs to be triaged.
With #13570, it is now possible to set the protocol version for ALB target groups, and thus make it working for GRPC.
However, it is not yet possible to define a GrpcCode for the matcher (see CloudFormation doc).
Use Case
Being able to define a custom GRPC Code for the matcher, like for HTTP Code
Proposed Solution
Add a
healthyGrpcCodes
working the same way ashealthyHttpCodes
.This is a 🚀 Feature Request
The text was updated successfully, but these errors were encountered: